Repository navigation
fix(ruflo-adr): use a key separator the memory validator accepts for edges - #3636
Merged
Merged
Conversation
…edges (ruvnet#3633) edgeKey() joined the endpoints with '->', and '>' is in the CLI's DANGEROUS_KEY_PATTERN, so every adr-edges store failed with "Key contains disallowed characters". Join with '__' instead; parseEdgeKey() still reads the earlier '->' keys so existing rows stay verifiable.
Owner
|
Shipped in v3.55.0. Thank you @drakeo338 for the contribution. 🤖 Generated with RuFlo |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3633.
edgeKey()in ruflo-adr joined the two ADR ids with->, and>is in the CLI'sDANGEROUS_KEY_PATTERN, so everyadr-edgesstore failed with "Key contains disallowed characters" and no edges were written.Edge keys now use
__between the ids.parseEdgeKey()accepts both__and->, in case any old-format row exists. The regression test fails on the old code (2 failing) and passes with the change; the other ruflo-adr script tests still pass (30/30).