You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
README feedback examples are silent no-ops — feedbackId is undocumented #21
Follow-up to #15 (thx for that fix — the loop does work now when driven via SearchOptions.feedbackId).
Problem: the README still teaches the old, broken pattern in all examples:
L45: backend.recordFeedback(results[0].id, 0.9);
L76: db.recordFeedback(hits[0].id, 1.0);
recordFeedback() looks up the trajectory by the feedbackId passed to searchAsync(q, k, { feedbackId }). A document id never matches, and the miss returns silently — so anyone coding from the README gets a no-op learning loop with no error. feedbackId currently appears nowhere in README or docs/ (grep on alpha.20).
Suggested:
Update the README examples to the feedbackId flow.
Document that recordFeedback() with an unknown id is ignored — or better, make that case throw/warn. A silent no-op on the headline feature is rough.
Also: #13 / #14 are fixed by #15 but still sitting open — they can be closed.
Activity