v0.102.3, bump aws-lc-rs from 1.6.4 to 1.7.0, MSRV 1.63#248
Conversation
Will need to admin merge this one & then fixup the branch protection rules 😮💨 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #248 +/- ##
=======================================
Coverage 97.21% 97.21%
=======================================
Files 19 19
Lines 4100 4100
=======================================
Hits 3986 3986
Misses 114 114 ☔ View full report in Codecov by Sentry. |
This will be a little annoying -- will mean we need to redo every Dependabot PR to keep jobserver pinned. Maybe this is the straw that has us move to 1.63? I think the fact that Debian stable has 1.63 makes this a common target for MSRV anyway, and it's still pretty conservative compared to most of the ecosystem. (tokio, hyper and reqwest are all at 1.63 -- Quinn is at 1.66, hickory-dns at 1.67.) 
|
Sounds good. We've been dancing around that decision a few times now. Let's just do it. |
Changing the runner image to `ubuntu-latest` takes a Ubuntu 22.04 image that includes GCC 11. This is notable because the latest aws-lc-rs build script bails[0] when compiled with a GCC version affected by a `memcpy` bug[1]. The 20.04 image uses GCC 9 and _is_ affected. We prefer `ubuntu-latest` in our other repositories so this change should be uncontroversial. [0]: https://github.com/aws/aws-lc-rs/blob/575f7d0656250e5302f8a9ce2ae34b3d098799b2/aws-lc-sys/builder/cc_builder.rs#L202-L260 [1]: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95189
We're seeing more of our deps move to this MSRV or higher and it's shipped in Debian stable. Time to move our MSRV to 1.63.
e6b528a to
d08b704
Compare
|
Dropped the commit pinning |
Tacked a version bump on here based on discussion in rustls/rustls#1902 |
cpu
changed the title
Another one that needs an admin merge + fixup because of the Ubuntu version change and the branch protection rules including the version string. |
Note: I also had to add one more item to the release notes than my proposal above to cover #229 Sorry for missing that up-front. |
3 participants
Replaces #246 A few additional changes are required above what was in #246:
proj: MSRV 1.61 -> 1.63
We're seeing more of our deps move to this MSRV or higher (in this case, a transitive dep on
jobserver) and it's shipped in Debian stable. Time to move our MSRV to 1.63.ci: ubuntu-20.04 -> ubuntu-latest
Changing the runner image to
ubuntu-latesttakes a Ubuntu 22.04 image that includes GCC 11. This is notable because the latest aws-lc-rs build script bails when compiled with a GCC version affected by a nastymemcpybug. The 20.04 image uses GCC 9 and is affected.We prefer
ubuntu-latestin our other repositories so this change should be uncontroversial.aws-lc-rs 1.7.0
Updates
aws-lc-rsfrom 1.6.4 to 1.7.0 (diff.rs). See upstream release notes for more information.Proposed Release Notes