Skip to content

build(deps): bump aws-lc-rs from 1.6.4 to 1.7.0#246

Closed
dependabot[bot] wants to merge 1 commit into
mainfrom
dependabot/cargo/aws-lc-rs-1.7.0
Closed

build(deps): bump aws-lc-rs from 1.6.4 to 1.7.0#246
dependabot[bot] wants to merge 1 commit into
mainfrom
dependabot/cargo/aws-lc-rs-1.7.0

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Apr 17, 2024

Copy link
Copy Markdown
Contributor

Bumps aws-lc-rs from 1.6.4 to 1.7.0.

Release notes

Sourced from aws-lc-rs's releases.

aws-lc-rs v1.7.0

What's Changed

  • RSA OAEP Support
  • The following platforms no longer require CMake for a (non-FIPS) build:
    • aarch64-apple-darwin
    • aarch64-unknown-linux-gnu
    • aarch64-unknown-linux-musl
    • x86_64-apple-darwin
    • x86_64-unknown-linux-gnu
    • x86_64-unknown-linux-musl
    • i686-unknown-linux-gnu
  • Newly available targets:
    • x86_64-apple-ios
    • x86_64-pc-windows-gnu

Merged PRs

Full Changelog: aws/aws-lc-rs@v1.6.4...v1.7.0

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot
build(deps): bump aws-lc-rs from 1.6.4 to 1.7.0
4eee66c 
Bumps [aws-lc-rs](https://github.com/awslabs/aws-lc-rs) from 1.6.4 to 1.7.0.
- [Release notes](https://github.com/awslabs/aws-lc-rs/releases)
- [Commits](aws/aws-lc-rs@v1.6.4...v1.7.0)

---
updated-dependencies:
- dependency-name: aws-lc-rs
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot Bot added dependencies Pull requests that update a dependency file rust Pull requests that update Rust code labels Apr 17, 2024
@cpu

cpu commented Apr 17, 2024

Copy link
Copy Markdown
Member

ci / Build+test (--all-features, --release, stable, ubuntu-20.04) (push) Failing after 16s

Will have to give this a closer look, it seems like a true positive failure of some kind.

@cpu

cpu commented Apr 17, 2024

Copy link
Copy Markdown
Member

I think the issue is related to the GCC version on ubuntu 20.04 runners, 4:9.3.0-1ubuntu2. In the CI failure output I see:

  --- stderr
  thread 'main' panicked at /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/aws-lc-sys-0.15.0/builder/cc_builder.rs:244:13:
  Your compiler (cc) is not supported due to a memcmp related bug reported in https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95189.We strongly recommend against using this compiler.EXECUTED: true ERROR:  OUTPUT:  
  note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
warning: build failed, waiting for other jobs to finish...

I can build/test this branch with the same Rust (1.77) and feature selection on my system using GCC 12.x. It looks like bumping the the runner images to ubuntu-latest (e.g. ubuntu 22.04 runner) brings along GCC 4:11.2.0-1ubuntu1 and compiles without issue.

I'll open a separate branch making that change in addition to the bump.

@cpu

cpu commented Apr 17, 2024

Copy link
Copy Markdown
Member

ci / MSRV (pull_request) Failing after 1m

This is another issue to sort out:

error: package jobserver v0.1.30 cannot be built because it requires rustc 1.63 or newer, while the currently active rustc version is 1.61.0

$ cargo tree --all-features
<snipped>
├── aws-lc-rs v1.7.0
│   ├── aws-lc-sys v0.15.0
│   │   ├── libc v0.2.153
│   │   └── paste v1.0.14 (proc-macro)
│   │   [build-dependencies]
│   │   ├── cc v1.0.90
│   │   │   ├── jobserver v0.1.27
│   │   │   │   └── libc v0.2.153
<snipped>

@cpu cpu mentioned this pull request Apr 17, 2024
Merged
@cpu

cpu commented Apr 17, 2024

Copy link
Copy Markdown
Member

Fixed all of the above in a replacement PR:

#248

@cpu cpu closed this Apr 17, 2024
@dependabot @github

dependabot Bot commented on behalf of github Apr 17, 2024

Copy link
Copy Markdown
Contributor Author

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot
dependabot Bot deleted the dependabot/cargo/aws-lc-rs-1.7.0 branch April 17, 2024 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

dependencies Pull requests that update a dependency file rust Pull requests that update Rust code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@cpu