Allow macOS 10.12 and 10.13 to work#194
Merged
Merged
Conversation
Contributor
Author
|
To be clear, the test suite does not pass on macOS 10.12, since the older function is being used there, while the test suite expects specific error message strings. I'll argue this is fine, the error messages are semi-internal anyhow, and the functionality is otherwise the same. |
djc
approved these changes
Sep 22, 2025
complexspaces
approved these changes
Sep 22, 2025
complexspaces
left a comment
complexspaces
left a comment
Collaborator
There was a problem hiding this comment.
This seems like the best path forward, all things considered.
Thank you for putting in the upstream work to make this a clean implementation!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since kornelski/rust-security-framework#243,
security-frameworknow dynamically looks up the newer symbolSecTrustEvaluateWithError, and only if it's not available does it fall back toSecTrustEvaluate. This allowsrustls-platform-verifierto support macOS 10.12 while still having good error messages on newer versions.Fixes #188.