Skip to content

Avoiding printing secrets in session types - #3299

Merged
ctz merged 2 commits into
mainfrom
jbp-debug-secrets
Sep 30, 2026
Merged

ctz merged 2 commits into
mainfrom
jbp-debug-secrets

Conversation

@ctz

@ctz ctz commented Sep 30, 2026

Copy link
Copy Markdown
Member

fixes #3298

@rustls-benchmarking

rustls-benchmarking Bot commented Sep 30, 2026 •

Copy link
Copy Markdown

Benchmark results

Instruction counts

Significant differences

⚠️ There are significant instruction count differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 1356166 1349821 ✅ -6345 (-0.47%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 3568910 3552892 ✅ -16018 (-0.45%) 0.24%

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_server 10959043 10926286 -32757 (-0.30%) 1.05%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_server 10412504 10438711 26207 (0.25%) 0.96%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 8759832 8772300 12468 (0.14%) 1.03%
handshake_no_resume_ring_1.3_ecdsap256_chacha_client 3265412 3261007 -4405 (-0.13%) 0.25%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_client 42463428 42515466 52038 (0.12%) 0.27%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_client 42524748 42476128 -48620 (-0.11%) 0.23%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_client 42482504 42519021 36517 (0.09%) 0.26%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_client 42460590 42496876 36286 (0.09%) 0.29%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_server 38466438 38497970 31532 (0.08%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_client 42147762 42114478 -33284 (-0.08%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_client 42127229 42157301 30072 (0.07%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_client 42114642 42142390 27748 (0.07%) 0.21%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_server 38473312 38448928 -24384 (-0.06%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_client 42130117 42156396 26279 (0.06%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_client 42489615 42513068 23453 (0.06%) 0.24%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_server 37013087 36993224 -19863 (-0.05%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 8776076 8780721 4645 (0.05%) 0.84%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_client 42155146 42177368 22222 (0.05%) 0.26%
handshake_no_resume_ring_1.3_ecdsap256_aes_client 3262244 3263958 1714 (0.05%) 0.24%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_server 37016124 37034587 18463 (0.05%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_server 38486861 38505177 18316 (0.05%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_server 37011469 37026032 14563 (0.04%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_server 36997668 37011424 13756 (0.04%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_server 37004129 37017348 13219 (0.04%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_server 38440121 38453415 13294 (0.03%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_server 10925954 10929484 3530 (0.03%) 1.34%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_server 38459802 38471586 11784 (0.03%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_client 2385464 2385167 -297 (-0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 1346588 1346457 -131 (-0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_client 42509046 42505385 -3661 (-0.01%) 0.36%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_client 2377605 2377804 199 (0.01%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_server 3503763 3503489 -274 (-0.01%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_client 42105978 42108713 2735 (0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 2270618 2270734 116 (0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_server 38483849 38482032 -1817 (-0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 3552508 3552368 -140 (-0.00%) 0.34%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 2274433 2274498 65 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_client 81716789 81717894 1105 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_server 36999603 36999438 -165 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_chacha_server 1231996 1231991 -5 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 47270244 47270081 -163 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_client 81717010 81716789 -221 (-0.00%) 0.20%
transfer_no_resume_1.2_no_crypto_client 106240537 106240758 221 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_client 34704897 34704897 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_client 30193646 30193646 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_server 31664948 31664948 0 (0.00%) 0.20%
handshake_tickets_1.3_no_crypto_server 1705175 1705175 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_server 31562907 31562907 0 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_server 45431600 45431600 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_server 1230815 1230815 0 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_server 79794927 79794927 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_client 30285659 30285659 0 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 70378989 70378989 0 (0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_server 45539786 45539786 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_server 7179290 7179290 0 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_client 4003048 4003048 0 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_server 79795000 79795000 0 (0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_client 47107728 47107728 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_server 31276933 31276933 0 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 35299789 35299789 0 (0.00%) 0.20%
transfer_no_resume_1.2_no_crypto_server 104451452 104451452 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_server 7181235 7181235 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_server 31565291 31565291 0 (0.00%) 0.20%
handshake_tickets_1.2_no_crypto_server 901969 901969 0 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 47269321 47269321 0 (0.00%) 0.20%
handshake_no_resume_1.3_no_crypto_client 63778 63778 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_server 31274158 31274158 0 (0.00%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_server 3623404 3623404 0 (0.00%) 0.20%
transfer_no_resume_1.3_no_crypto_server 104460840 104460840 0 (0.00%) 0.20%
handshake_no_resume_1.3_no_crypto_server 55422 55422 0 (0.00%) 0.20%
handshake_session_id_1.3_no_crypto_server 1738981 1738981 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_client 30194639 30194639 0 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 70379069 70379069 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_client 34706612 34706612 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_client 30203644 30203644 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_client 30299215 30299215 0 (0.00%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_client 3195160 3195160 0 (0.00%) 0.20%
handshake_tickets_1.2_no_crypto_client 963246 963246 0 (0.00%) 0.20%
handshake_tickets_1.3_no_crypto_client 1928267 1928267 0 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_client 47056135 47056135 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_server 11064931 11064931 0 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_client 81701175 81701175 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_client 30284666 30284666 0 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 81790121 81790121 0 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_server 35299686 35299686 0 (0.00%) 0.20%
handshake_no_resume_1.2_no_crypto_server 35852 35852 0 (0.00%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_server 3062313 3062313 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_server 31275248 31275248 0 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_server 4576705 4576705 0 (0.00%) 1.02%
handshake_tickets_ring_1.3_ecdsap384_aes_server 31665482 31665482 0 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_client 47070389 47070389 0 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_client 81792273 81792273 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_client 2294080 2294080 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_server 31396438 31396438 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_client 30294634 30294634 0 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_server 70378808 70378808 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_server 11059183 11059183 0 (0.00%) 0.20%
handshake_no_resume_1.2_no_crypto_client 53907 53907 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_client 30371734 30371734 0 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_server 45431527 45431527 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_server 31397528 31397528 0 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_server 45431651 45431651 0 (0.00%) 0.20%
transfer_no_resume_1.3_no_crypto_client 106273434 106273434 0 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 35299869 35299869 0 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_server 35218204 35218204 0 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_client 47243773 47243773 0 (0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_server 10899534 10899534 0 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_client 47070389 47070389 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_server 31668401 31668401 0 (0.00%) 0.20%
handshake_session_id_1.2_no_crypto_client 894886 894886 0 (0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_client 2165933 2165933 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_server 31566707 31566707 0 (0.00%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_client 3574376 3574376 0 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_server 79795051 79795051 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_client 30298168 30298168 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_client 30309874 30309874 0 (0.00%) 0.20%
handshake_session_id_1.2_no_crypto_server 774044 774044 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_client 30381424 30381424 0 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 81790041 81790041 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_server 31399213 31399213 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_client 2299730 2299730 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_client 30370817 30370817 0 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_client 47312175 47312175 0 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_client 3624419 3624419 0 (0.00%) 0.20%
handshake_session_id_1.3_no_crypto_client 1920022 1920022 0 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_client 1679677 1679677 0 (0.00%) 0.20%

Wall-time

Significant differences

There are no significant wall-time differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_session_id_1.3_no_crypto 523.22 µs 535.06 µs 11.84 µs (2.26%) 4.49%
handshake_no_resume_1.3_no_crypto 44.26 µs 45.18 µs 0.92 µs (2.08%) 9.16%
handshake_tickets_1.3_no_crypto 510.08 µs 519.29 µs 9.21 µs (1.81%) 4.89%
handshake_no_resume_1.2_no_crypto 47.26 µs 47.92 µs 0.66 µs (1.40%) 8.63%
handshake_tickets_1.2_no_crypto 297.80 µs 301.58 µs 3.78 µs (1.27%) 4.34%
handshake_tickets_aws_lc_rs_1.2_rsa_aes 1.67 ms 1.68 ms 0.01 ms (0.87%) 2.37%
handshake_session_id_1.2_no_crypto 272.01 µs 274.25 µs 2.24 µs (0.82%) 5.37%
handshake_tickets_ring_1.2_rsa_aes 1.42 ms 1.43 ms 0.01 ms (0.76%) 1.26%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 462.35 µs 465.67 µs 3.32 µs (0.72%) 2.43%
handshake_session_id_ring_1.2_rsa_aes 1.34 ms 1.35 ms 0.01 ms (0.63%) 1.15%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes 479.83 µs 482.21 µs 2.38 µs (0.50%) 2.75%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes 6.27 ms 6.30 ms 0.03 ms (0.49%) 1.79%
handshake_session_id_aws_lc_rs_1.2_rsa_aes 1.52 ms 1.53 ms 0.01 ms (0.48%) 2.70%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes 6.92 ms 6.95 ms 0.03 ms (0.47%) 1.59%
handshake_session_id_ring_1.3_ecdsap256_chacha 5.23 ms 5.25 ms 0.02 ms (0.45%) 1.03%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes 7.12 ms 7.15 ms 0.03 ms (0.41%) 1.45%
handshake_session_id_aws_lc_rs_1.3_rsa_aes 6.90 ms 6.93 ms 0.03 ms (0.41%) 1.33%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes 6.46 ms 6.49 ms 0.03 ms (0.40%) 1.87%
handshake_tickets_ring_1.3_ecdsap256_aes 5.33 ms 5.36 ms 0.02 ms (0.39%) 1.24%
handshake_tickets_aws_lc_rs_1.3_rsa_aes 7.10 ms 7.12 ms 0.03 ms (0.39%) 1.71%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha 6.23 ms 6.25 ms 0.02 ms (0.39%) 1.43%
handshake_session_id_ring_1.3_ecdsap256_aes 5.28 ms 5.30 ms 0.02 ms (0.37%) 1.10%
handshake_session_id_ring_1.3_rsa_chacha 5.72 ms 5.75 ms 0.02 ms (0.37%) 1.00%
handshake_tickets_ring_1.3_rsa_aes 5.81 ms 5.83 ms 0.02 ms (0.34%) 1.11%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha 7.11 ms 7.13 ms 0.02 ms (0.34%) 1.31%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha 6.43 ms 6.45 ms 0.02 ms (0.33%) 1.65%
handshake_tickets_ring_1.3_rsa_chacha 5.78 ms 5.80 ms 0.02 ms (0.33%) 1.02%
handshake_tickets_ring_1.3_ecdsap256_chacha 5.29 ms 5.31 ms 0.02 ms (0.32%) 1.13%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha 6.90 ms 6.92 ms 0.02 ms (0.32%) 1.45%
handshake_no_resume_ring_1.3_ecdsap256_aes 424.39 µs 425.73 µs 1.34 µs (0.32%) 1.83%
handshake_session_id_ring_1.3_rsa_aes 5.76 ms 5.78 ms 0.02 ms (0.32%) 1.17%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha 6.91 ms 6.93 ms 0.02 ms (0.32%) 1.41%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha 7.11 ms 7.13 ms 0.02 ms (0.29%) 1.57%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 1.14 ms 1.15 ms 0.00 ms (0.28%) 1.11%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes 1.16 ms 1.16 ms 0.00 ms (0.27%) 1.00%
handshake_session_id_ring_1.3_ecdsap384_chacha 8.32 ms 8.34 ms 0.02 ms (0.27%) 1.00%
handshake_tickets_ring_1.3_ecdsap384_aes 8.42 ms 8.44 ms 0.02 ms (0.27%) 1.00%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha 1.13 ms 1.13 ms 0.00 ms (0.26%) 1.55%
handshake_tickets_ring_1.3_ecdsap384_chacha 8.38 ms 8.40 ms 0.02 ms (0.25%) 1.00%
handshake_no_resume_ring_1.3_ecdsap256_chacha 414.72 µs 415.69 µs 0.97 µs (0.23%) 1.77%
handshake_session_id_ring_1.3_ecdsap384_aes 8.36 ms 8.38 ms 0.02 ms (0.23%) 1.00%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes 1.11 ms 1.11 ms 0.00 ms (0.21%) 2.51%
handshake_no_resume_ring_1.3_rsa_aes 905.75 µs 907.35 µs 1.60 µs (0.18%) 1.00%
transfer_no_resume_ring_1.2_rsa_aes 5.40 ms 5.41 ms 0.01 ms (0.17%) 3.33%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes 4.42 ms 4.43 ms 0.01 ms (0.16%) 3.65%
transfer_no_resume_1.2_no_crypto 11.29 ms 11.30 ms 0.02 ms (0.15%) 2.41%
handshake_no_resume_ring_1.3_rsa_chacha 900.33 µs 901.71 µs 1.38 µs (0.15%) 1.00%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes 1.03 ms 1.03 ms 0.00 ms (0.14%) 2.29%
transfer_no_resume_1.3_no_crypto 11.48 ms 11.49 ms 0.01 ms (0.13%) 3.17%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes 4.56 ms 4.57 ms 0.01 ms (0.12%) 3.61%
handshake_no_resume_ring_1.2_rsa_aes 905.41 µs 906.47 µs 1.06 µs (0.12%) 1.00%
transfer_no_resume_ring_1.3_ecdsap256_aes 4.95 ms 4.95 ms 0.01 ms (0.12%) 4.19%
transfer_no_resume_ring_1.3_rsa_chacha 13.00 ms 13.02 ms 0.01 ms (0.09%) 1.62%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 12.55 ms 12.56 ms 0.01 ms (0.08%) 1.61%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha 13.20 ms 13.20 ms 0.01 ms (0.07%) 1.53%
transfer_no_resume_ring_1.3_ecdsap256_chacha 12.52 ms 12.53 ms 0.01 ms (0.06%) 1.86%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes 4.61 ms 4.61 ms 0.00 ms (0.06%) 4.03%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 13.22 ms 13.23 ms 0.01 ms (0.06%) 1.56%
transfer_no_resume_ring_1.3_ecdsap384_chacha 15.61 ms 15.62 ms 0.01 ms (0.05%) 1.36%
handshake_no_resume_ring_1.3_ecdsap384_chacha 3.51 ms 3.51 ms 0.00 ms (0.04%) 1.00%
transfer_no_resume_ring_1.3_rsa_aes 5.44 ms 5.43 ms -0.00 ms (-0.04%) 4.21%
handshake_no_resume_ring_1.3_ecdsap384_aes 3.52 ms 3.52 ms 0.00 ms (0.03%) 1.00%
transfer_no_resume_ring_1.3_ecdsap384_aes 8.04 ms 8.04 ms 0.00 ms (0.02%) 2.45%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes 3.93 ms 3.93 ms -0.00 ms (-0.00%) 4.90%

Memory usage

Key:

  • ∑: sum usage for entire benchmark run
  • 🔝: peak usage
  • B: bytes
  • a: allocations

Significant differences

There are no significant memory usage differences

Additional information

Historical results

Checkout details:

@codecov

codecov Bot commented Sep 30, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.52%. Comparing base (26c5520) to head (94f87f3).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3299      +/-   ##
==========================================
+ Coverage   95.50%   95.52%   +0.01%     
==========================================
  Files          99       99              
  Lines       23991    24096     +105     
  Branches      688      688              
==========================================
+ Hits        22912    23017     +105     
  Misses        918      918              
  Partials      161      161              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@djc djc left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have also have quic session types that need similar treatment?

Comment thread rustls/src/client/mod.rs Resolved
@ctz
ctz force-pushed the jbp-debug-secrets branch from 82e11e6 to d3a13fc Compare September 30, 2026 14:26
@ctz
ctz force-pushed the jbp-debug-secrets branch from d3a13fc to 94f87f3 Compare September 30, 2026 14:32
@ctz

ctz commented Sep 30, 2026

Copy link
Copy Markdown
Member Author

Do we have also have quic session types that need similar treatment?

Nope!

@ctz
ctz added this pull request to the merge queue Sep 30, 2026
Merged via the queue into main with commit cf42c85 Sep 30, 2026
30 checks passed
@ctz
ctz deleted the jbp-debug-secrets branch September 30, 2026 14:55
@djc djc mentioned this pull request Oct 13, 2026
jdx added a commit to jdx/mise that referenced this pull request Oct 14, 2026
<!-- entire-trail-link-start -->
https://entire.io/gh/jdx/mise/trails/724
<!-- entire-trail-link-end -->

`cargo deny check` now fails on rustls 0.23.45: its `Debug` impls for
`Tls12ClientSessionValue` and `Tls13ClientSessionValue` print the TLS
1.2 master secret or TLS 1.3 resumption PSK (rustls/rustls#3299, fixed
in 0.23.46). The advisory is not yet numbered (`RUSTSEC-0000-0000`).
This makes `trusted / lint` red on every open PR.

mise does not format those values with `Debug`; the dependency path is
the AWS SDK's HTTP client, so the exposure is limited to anything that
would log a custom session store's values. The bump is a lockfile-only
change (`cargo update -p rustls --precise 0.23.46`; it also moves
rustls's `getrandom` dependency from 0.4.3 to 0.3.4), with no
`Cargo.toml` change.

Validation: `cargo check --bin mise` builds. I could not run `cargo
deny` locally (the shim has no installed version here), so CI's `trusted
/ lint` is the check.

*AI-assisted — Tool: Claude Code; model: anthropic/claude-sonnet-5-5;
version: claude-code_2-1-295_agent.*

🤖 Generated with [Claude Code](https://claude.com/claude-code)

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Low Risk**
> Patch-level TLS library upgrade with no application code changes;
reduces secret-leak risk in debug output rather than changing runtime
TLS behavior.
> 
> **Overview**
> Bumps **rustls** from `0.23.45` to `0.23.46` in `Cargo.lock` only (no
`Cargo.toml` edits), addressing a pending RustSec issue where `Debug` on
TLS session types could leak the TLS 1.2 master secret or TLS 1.3
resumption PSK—fixing failing `cargo deny` / `trusted / lint` on PRs.
> 
> The lockfile refresh also pins **tempfile**’s transitive **getrandom**
dependency to `0.3.4` instead of `0.4.3` as part of the same `cargo
update -p rustls` resolution.
> 
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit
e74cbfd. Bugbot is set up for automated
code reviews on this repo. Configure
[here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->

Co-authored-by: Claude Sonnet 5.5 <[email protected]>
This was referenced Oct 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

F02: Session Debug formatting exposes TLS master secrets and resumption PSKs

2 participants