Repository navigation
Avoiding printing secrets in session types - #3299
Merged
Merged
Conversation
Benchmark resultsInstruction countsSignificant differencesClick to expand
Other differencesClick to expand
Wall-timeSignificant differencesThere are no significant wall-time differences Other differencesClick to expand
Memory usageKey:
Significant differencesThere are no significant memory usage differences Additional informationCheckout details:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3299 +/- ##
==========================================
+ Coverage 95.50% 95.52% +0.01%
==========================================
Files 99 99
Lines 23991 24096 +105
Branches 688 688
==========================================
+ Hits 22912 23017 +105
Misses 918 918
Partials 161 161 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
djc
reviewed
Sep 30, 2026
djc
left a comment
Member
There was a problem hiding this comment.
Do we have also have quic session types that need similar treatment?
ctz
force-pushed
the
jbp-debug-secrets
branch
from
September 30, 2026 14:26
82e11e6 to
d3a13fc
Compare
djc
approved these changes
Sep 30, 2026
ctz
force-pushed
the
jbp-debug-secrets
branch
from
September 30, 2026 14:32
d3a13fc to
94f87f3
Compare
Member
Author
Nope! |
Merged
jdx
added a commit
to jdx/mise
that referenced
this pull request
Oct 14, 2026
<!-- entire-trail-link-start --> https://entire.io/gh/jdx/mise/trails/724 <!-- entire-trail-link-end --> `cargo deny check` now fails on rustls 0.23.45: its `Debug` impls for `Tls12ClientSessionValue` and `Tls13ClientSessionValue` print the TLS 1.2 master secret or TLS 1.3 resumption PSK (rustls/rustls#3299, fixed in 0.23.46). The advisory is not yet numbered (`RUSTSEC-0000-0000`). This makes `trusted / lint` red on every open PR. mise does not format those values with `Debug`; the dependency path is the AWS SDK's HTTP client, so the exposure is limited to anything that would log a custom session store's values. The bump is a lockfile-only change (`cargo update -p rustls --precise 0.23.46`; it also moves rustls's `getrandom` dependency from 0.4.3 to 0.3.4), with no `Cargo.toml` change. Validation: `cargo check --bin mise` builds. I could not run `cargo deny` locally (the shim has no installed version here), so CI's `trusted / lint` is the check. *AI-assisted — Tool: Claude Code; model: anthropic/claude-sonnet-5-5; version: claude-code_2-1-295_agent.* 🤖 Generated with [Claude Code](https://claude.com/claude-code) <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Patch-level TLS library upgrade with no application code changes; reduces secret-leak risk in debug output rather than changing runtime TLS behavior. > > **Overview** > Bumps **rustls** from `0.23.45` to `0.23.46` in `Cargo.lock` only (no `Cargo.toml` edits), addressing a pending RustSec issue where `Debug` on TLS session types could leak the TLS 1.2 master secret or TLS 1.3 resumption PSK—fixing failing `cargo deny` / `trusted / lint` on PRs. > > The lockfile refresh also pins **tempfile**’s transitive **getrandom** dependency to `0.3.4` instead of `0.4.3` as part of the same `cargo update -p rustls` resolution. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit e74cbfd. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY --> Co-authored-by: Claude Sonnet 5.5 <[email protected]>
This was referenced Oct 14, 2026
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Oct 26, 2026
Merged
Merged
Merged
Merged
Merged
Merged
Open
Merged
This was referenced Oct 28, 2026
Open
1 of 3 tasks
This was referenced Nov 10, 2026
Open
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #3298