ech: implement inner hello extension compression#2001
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2001 +/- ##
==========================================
+ Coverage 94.17% 94.18% +0.01%
==========================================
Files 97 97
Lines 21566 21640 +74
==========================================
+ Hits 20309 20382 +73
- Misses 1257 1258 +1 ☔ View full report in Codecov by Sentry. |
cpu
force-pushed
the
cpu-client-ech-compress-exts-rebase
branch
from
June 12, 2024 14:57
5fead9d to
3ccbdcf
Compare
djc
approved these changes
Jun 13, 2024
Benchmark resultsInstruction countsSignificant differencesClick to expand
Other differencesClick to expand
Wall-timeSignificant differencesThere are no significant wall-time differences Other differencesClick to expand
Additional informationCheckout details:
|
ctz
approved these changes
Jun 13, 2024
ctz
left a comment
ctz
left a comment
Member
There was a problem hiding this comment.
A couple of things unrelated to this PR I noticed while reviewing:
The head comment in examples/src/bin/ech-client.rs has an example usage that wants to find ech-client in the rustls-provider-example crate; it has moved since.
It would be nice if cargo run --bin ech-client -- --help included an example usage.
Do we want to run ech-client in the connect-tests job?
This commit extends the existing client-side ECH support to enable the "SHOULD" recommendation of compressing extensions that are identical between the outer client hello and the inner client hello. This optimization reduces the overhead of ECH, shrinking the total client hello size. Achieving this is a bit tricky (which is why it was done separately at the end!). To-be-compressed extensions must be in a contiguous block in the inner hello. When we encode that contiguous block for the encoded inner hello, we replace the block with a marker extension listing all of the extension types that were replaced. In the outer hello the compressed extensions must be present in the same relative order (but don't need to be contiguous). With this feature implemented we can also activate a couple of bogo tests that were previously excluded.
Use `log::trace!` for writing the current & total number of requests being made instead of a bare `println!`.
The ech-client was moved from the provider-example crate into the examples crate, but the usage example in the header comment wasn't updated.
Also 'grep' for the HTML output that's rendered when ECH was successful.
cpu
force-pushed
the
cpu-client-ech-compress-exts-rebase
branch
from
June 13, 2024 13:46
3ccbdcf to
3271e01
Compare
djc
approved these changes
Jun 13, 2024
Member
Author
Good catch, thanks. Fixed.
Done.
I added a test invocation of the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit extends the initial client-side ECH support from #1718 to enable the "SHOULD" recommendation of compressing extensions that are identical between the outer client hello and the inner client hello. This optimization reduces the overhead of ECH, shrinking the total client hello size.
Achieving this is a bit tricky (which is why it was done separately at the end!). To-be-compressed extensions must be in a contiguous block in the inner hello. When we encode that contiguous block for the encoded inner hello, we replace the block with a marker extension listing all of the extension types that were replaced. In the outer hello the compressed extensions must be present in the same relative order (but don't need to be contiguous). We also need the uncompressed inner hello with the uncompressed extensions in place to update the inner transcript.
With this feature implemented we can also activate a couple of bogo tests that were previously excluded.