Conversation
cpu
approved these changes
Feb 27, 2024
Benchmark resultsInstruction countsSignificant differencesThere are no significant instruction count differences Other differencesClick to expand
Wall-timeSignificant differencesClick to expand
Other differencesClick to expand
Additional informationCheckout details:
|
637a001 to
ec1ba67
Compare
djc
approved these changes
Feb 27, 2024
ec1ba67 to
8de5097
Compare
cpu
approved these changes
Feb 27, 2024
"warning: the item `rustls` is imported redundantly"
"warning: the item `CertificateChain` is imported redundantly" "warning: the item `SessionId` is imported redundantly"
"warning: you are explicitly cloning with `.map()`"
"warning: the item `rustls` is imported redundantly"
This fixes a wedge of instances of: ``` warning: the item `String` is imported redundantly --> rustls/src/msgs/handshake.rs:27:5 | 27 | use alloc::string::String; | ^^^^^^^^^^^^^^^^^^^^^ ``` Where `String` is present from the std prelude when built for testing. Like we just did in webpki, _always_ opt-in to no_std, and then import the std prelude in tests where necessary.
This is a complete mock for `rustls::client::ClientSessionStore`, but we don't have tests that use 100% of its abilities.
8de5097 to
ab81ef8
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1813 +/- ##
=======================================
Coverage 95.98% 95.98%
=======================================
Files 84 84
Lines 18791 18794 +3
=======================================
+ Hits 18036 18039 +3
Misses 755 755 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes one new nightly clippy lint, plus a heap of new nightly warnings to do with redundant imports.
rustls/webpki#234 is the similar change in webpki.