Skip to content

Fix new nightly warnings#1813

Merged
ctz merged 6 commits intomainfrom
jbp-nightly-clippy-3
Feb 27, 2024
Merged

Fix new nightly warnings#1813
ctz merged 6 commits intomainfrom
jbp-nightly-clippy-3

Conversation

@ctz
Copy link
Member

@ctz ctz commented Feb 27, 2024

This fixes one new nightly clippy lint, plus a heap of new nightly warnings to do with redundant imports.

rustls/webpki#234 is the similar change in webpki.

@rustls-benchmarking
Copy link

rustls-benchmarking bot commented Feb 27, 2024

Benchmark results

Instruction counts

Significant differences

There are no significant instruction count differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_tickets_aws_lc_rs_1.2_rsa_aes_server 4506541 4521509 14968 (0.33%) 2.64%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_server 32344993 32435071 90078 (0.28%) 0.52%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_server 12328042 12296727 -31315 (-0.25%) 1.27%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 8675301 8653882 -21419 (-0.25%) 0.96%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_client 4190026 4181404 -8622 (-0.21%) 0.95%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_server 12736280 12714164 -22116 (-0.17%) 0.88%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_server 12663933 12685418 21485 (0.17%) 0.93%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_client 30400271 30450194 49923 (0.16%) 0.51%
handshake_session_id_ring_1.2_rsa_aes_client 4443831 4436707 -7124 (-0.16%) 0.85%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_client 4511942 4517157 5215 (0.12%) 1.02%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_server 32470223 32437768 -32455 (-0.10%) 0.43%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_client 30266363 30238513 -27850 (-0.09%) 0.34%
handshake_session_id_ring_1.3_ecdsap256_chacha_server 43461470 43425333 -36137 (-0.08%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_server 32598534 32623412 24878 (0.08%) 0.25%
handshake_session_id_ring_1.2_rsa_aes_server 4326132 4329113 2981 (0.07%) 0.52%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_server 32432627 32411644 -20983 (-0.06%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 8662495 8667634 5139 (0.06%) 0.78%
handshake_session_id_ring_1.3_ecdsap256_aes_server 43556737 43531358 -25379 (-0.06%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_client 30427357 30409712 -17645 (-0.06%) 0.27%
handshake_tickets_ring_1.2_rsa_aes_server 4767000 4764253 -2747 (-0.06%) 0.60%
handshake_tickets_ring_1.3_ecdsap256_aes_server 43762623 43737587 -25036 (-0.06%) 0.33%
handshake_tickets_ring_1.3_ecdsap384_aes_server 43750847 43726783 -24064 (-0.06%) 0.23%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_server 32585403 32603224 17821 (0.05%) 0.34%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_server 46177001 46201365 24364 (0.05%) 0.32%
handshake_tickets_ring_1.3_rsa_aes_server 43800891 43778322 -22569 (-0.05%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_server 43653459 43675374 21915 (0.05%) 0.21%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 57943896 57972717 28821 (0.05%) 0.22%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_server 32398234 32413908 15674 (0.05%) 0.30%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_server 32655567 32640527 -15040 (-0.05%) 0.83%
handshake_session_id_ring_1.3_ecdsap384_chacha_server 43430561 43449259 18698 (0.04%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_server 43668635 43686530 17895 (0.04%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_server 32420150 32407045 -13105 (-0.04%) 0.30%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_server 32587590 32600750 13160 (0.04%) 0.29%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_client 30422081 30409895 -12186 (-0.04%) 0.22%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_server 32421101 32433344 12243 (0.04%) 0.25%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_client 30418734 30407365 -11369 (-0.04%) 0.31%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_client 30620973 30631509 10536 (0.03%) 0.22%
handshake_tickets_ring_1.3_ecdsap384_aes_client 42175234 42160871 -14363 (-0.03%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_server 13730186 13734180 3994 (0.03%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_client 41922480 41934513 12033 (0.03%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_server 4039917 4041020 1103 (0.03%) 3.58%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_server 46190211 46201763 11552 (0.03%) 0.32%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 92446529 92468291 21762 (0.02%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_server 46301101 46290332 -10769 (-0.02%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_chacha_server 2128650 2129116 466 (0.02%) 0.31%
handshake_tickets_ring_1.3_ecdsap256_aes_client 42170870 42179840 8970 (0.02%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_client 4537674 4538552 878 (0.02%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_server 32586976 32592939 5963 (0.02%) 0.61%
transfer_no_resume_ring_1.3_ecdsap384_aes_server 46306800 46298351 -8449 (-0.02%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_client 41909944 41917585 7641 (0.02%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 46254890 46246642 -8248 (-0.02%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_client 42107936 42100589 -7347 (-0.02%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_chacha_client 3899069 3899738 669 (0.02%) 0.35%
transfer_no_resume_ring_1.3_ecdsap384_aes_client 58068969 58059511 -9458 (-0.02%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 3340758 3340248 -510 (-0.02%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_client 35447909 35452912 5003 (0.01%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_server 43550819 43556808 5989 (0.01%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_client 42385753 42380083 -5670 (-0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_client 30395624 30399643 4019 (0.01%) 0.30%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_client 30230871 30234822 3951 (0.01%) 0.49%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_client 3365450 3365886 436 (0.01%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 80454841 80444793 -10048 (-0.01%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_server 80353568 80343915 -9653 (-0.01%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_client 41995397 41990423 -4974 (-0.01%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_client 42123723 42128403 4680 (0.01%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_client 30217781 30214445 -3336 (-0.01%) 0.22%
handshake_tickets_ring_1.3_rsa_chacha_client 42314008 42318479 4471 (0.01%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_client 30446484 30443672 -2812 (-0.01%) 0.21%
handshake_tickets_ring_1.3_rsa_chacha_server 43707261 43703365 -3896 (-0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_client 30640187 30637537 -2650 (-0.01%) 0.31%
handshake_tickets_ring_1.3_ecdsap256_chacha_client 42102189 42098667 -3522 (-0.01%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_client 3897428 3897749 321 (0.01%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_server 80440983 80434388 -6595 (-0.01%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_server 80346919 80352850 5931 (0.01%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_client 42204813 42201760 -3053 (-0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 4256740 4256433 -307 (-0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_client 3354729 3354525 -204 (-0.01%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_server 80350944 80355464 4520 (0.01%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_client 4711784 4711542 -242 (-0.01%) 0.74%
transfer_no_resume_ring_1.3_ecdsap384_chacha_client 92393058 92397290 4232 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 1881901 1881822 -79 (-0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_client 4440287 4440465 178 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 57963340 57965432 2092 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_server 43436856 43438393 1537 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_client 58062320 58064322 2002 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 4261155 4261298 143 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_server 12237024 12237385 361 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_server 32617613 32616765 -848 (-0.00%) 0.27%
handshake_no_resume_ring_1.3_ecdsap384_chacha_server 13737417 13737068 -349 (-0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_client 42009643 42010709 1066 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 92432247 92434443 2196 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_client 30221135 30220456 -679 (-0.00%) 0.45%
transfer_no_resume_ring_1.3_rsa_aes_client 58064803 58063652 -1151 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_server 12246354 12246564 210 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_client 4547372 4547436 64 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_client 92398189 92396904 -1285 (-0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_server 43534709 43534111 -598 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_client 92456198 92455170 -1028 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_client 92395271 92394281 -990 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_server 2126549 2126531 -18 (-0.00%) 0.31%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 3344042 3344067 25 (0.00%) 0.23%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_client 57986016 57986447 431 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 1878298 1878309 11 (0.00%) 0.21%
transfer_no_resume_ring_1.2_rsa_aes_server 46176243 46176508 265 (0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_client 57920540 57920246 -294 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 46265179 46264985 -194 (-0.00%) 0.25%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_client 68386376 68386545 169 (0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_server 12042331 12042354 23 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_client 3151476 3151479 3 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_client 35454776 35454808 32 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_server 46293819 46293844 25 (0.00%) 0.25%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 80455077 80455038 -39 (-0.00%) 0.20%

Wall-time

Significant differences

⚠️ There are significant wall-time differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_ring_1.3_ecdsap384_chacha 3.61 ms 3.67 ms ⚠️ 0.06 ms (1.57%) 1.33%
handshake_no_resume_ring_1.3_ecdsap384_aes 3.61 ms 3.67 ms ⚠️ 0.06 ms (1.56%) 1.11%

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes 4.75 ms 4.84 ms 0.09 ms (1.88%) 4.39%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes 5.47 ms 5.55 ms 0.09 ms (1.58%) 3.75%
transfer_no_resume_ring_1.3_ecdsap384_aes 9.68 ms 9.82 ms 0.15 ms (1.50%) 2.50%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes 5.70 ms 5.78 ms 0.09 ms (1.49%) 2.81%
handshake_session_id_ring_1.3_ecdsap384_chacha 9.95 ms 10.08 ms 0.13 ms (1.34%) 1.94%
transfer_no_resume_ring_1.3_ecdsap256_aes 6.58 ms 6.66 ms 0.09 ms (1.31%) 3.46%
transfer_no_resume_ring_1.3_rsa_aes 7.15 ms 7.24 ms 0.09 ms (1.26%) 2.53%
handshake_tickets_ring_1.3_ecdsap384_chacha 9.97 ms 10.10 ms 0.12 ms (1.25%) 2.27%
handshake_session_id_ring_1.3_rsa_chacha 7.47 ms 7.56 ms 0.09 ms (1.24%) 2.26%
handshake_tickets_ring_1.3_ecdsap384_aes 10.02 ms 10.14 ms 0.12 ms (1.23%) 2.20%
handshake_session_id_ring_1.3_ecdsap384_aes 9.98 ms 10.11 ms 0.12 ms (1.23%) 1.69%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes 5.68 ms 5.75 ms 0.07 ms (1.21%) 3.45%
handshake_no_resume_ring_1.3_ecdsap256_chacha 503.57 µs 509.27 µs 5.69 µs (1.13%) 2.28%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes 5.46 ms 5.39 ms -0.06 ms (-1.13%) 2.26%
handshake_tickets_ring_1.3_rsa_chacha 7.49 ms 7.57 ms 0.08 ms (1.06%) 2.03%
handshake_tickets_ring_1.3_ecdsap256_chacha 6.86 ms 6.94 ms 0.07 ms (1.05%) 2.05%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes 5.43 ms 5.37 ms -0.06 ms (-1.03%) 1.92%
handshake_session_id_ring_1.3_ecdsap256_chacha 6.85 ms 6.92 ms 0.07 ms (1.01%) 2.28%
handshake_no_resume_ring_1.3_ecdsap256_aes 505.92 µs 510.95 µs 5.03 µs (0.99%) 2.41%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes 6.14 ms 6.08 ms -0.06 ms (-0.99%) 1.72%
handshake_session_id_ring_1.3_rsa_aes 7.52 ms 7.60 ms 0.07 ms (0.96%) 1.78%
handshake_tickets_ring_1.3_ecdsap256_aes 6.92 ms 6.98 ms 0.07 ms (0.94%) 1.90%
handshake_session_id_ring_1.3_ecdsap256_aes 6.89 ms 6.96 ms 0.06 ms (0.92%) 1.81%
handshake_tickets_aws_lc_rs_1.3_rsa_aes 6.45 ms 6.39 ms -0.06 ms (-0.91%) 1.89%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes 6.17 ms 6.12 ms -0.06 ms (-0.90%) 1.87%
transfer_no_resume_ring_1.3_ecdsap384_chacha 16.34 ms 16.49 ms 0.15 ms (0.90%) 1.50%
handshake_tickets_ring_1.3_rsa_aes 7.55 ms 7.62 ms 0.07 ms (0.86%) 1.75%
transfer_no_resume_ring_1.2_rsa_aes 7.07 ms 7.13 ms 0.06 ms (0.81%) 2.97%
handshake_session_id_aws_lc_rs_1.3_rsa_aes 6.43 ms 6.38 ms -0.05 ms (-0.75%) 1.72%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha 5.44 ms 5.40 ms -0.04 ms (-0.74%) 2.54%
transfer_no_resume_ring_1.3_ecdsap256_chacha 13.24 ms 13.34 ms 0.10 ms (0.72%) 1.63%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 13.23 ms 13.32 ms 0.09 ms (0.70%) 1.48%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 13.93 ms 14.03 ms 0.09 ms (0.68%) 1.64%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha 5.41 ms 5.37 ms -0.04 ms (-0.67%) 2.09%
handshake_no_resume_ring_1.2_rsa_aes 1.07 ms 1.08 ms 0.01 ms (0.66%) 1.05%
handshake_session_id_ring_1.2_rsa_aes 1.75 ms 1.76 ms 0.01 ms (0.66%) 2.57%
transfer_no_resume_ring_1.3_rsa_chacha 13.82 ms 13.91 ms 0.09 ms (0.65%) 1.55%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha 14.17 ms 14.26 ms 0.08 ms (0.60%) 1.41%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha 6.15 ms 6.11 ms -0.04 ms (-0.58%) 2.11%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha 6.10 ms 6.07 ms -0.03 ms (-0.55%) 1.86%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha 6.44 ms 6.40 ms -0.03 ms (-0.54%) 2.19%
handshake_tickets_ring_1.2_rsa_aes 1.84 ms 1.85 ms 0.01 ms (0.50%) 1.63%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha 6.40 ms 6.37 ms -0.03 ms (-0.50%) 2.09%
handshake_no_resume_ring_1.3_rsa_chacha 1.08 ms 1.09 ms 0.01 ms (0.46%) 1.00%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 474.60 µs 476.69 µs 2.09 µs (0.44%) 2.90%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes 476.14 µs 477.99 µs 1.84 µs (0.39%) 2.23%
handshake_no_resume_ring_1.3_rsa_aes 1.08 ms 1.08 ms 0.00 ms (0.32%) 1.00%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes 1.36 ms 1.36 ms 0.00 ms (0.21%) 1.02%
handshake_tickets_aws_lc_rs_1.2_rsa_aes 2.34 ms 2.33 ms -0.00 ms (-0.13%) 1.73%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes 1.19 ms 1.19 ms -0.00 ms (-0.10%) 1.00%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 1.18 ms 1.18 ms -0.00 ms (-0.07%) 1.10%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha 1.41 ms 1.41 ms 0.00 ms (0.07%) 1.00%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes 1.42 ms 1.41 ms -0.00 ms (-0.07%) 1.00%
handshake_session_id_aws_lc_rs_1.2_rsa_aes 2.17 ms 2.17 ms -0.00 ms (-0.06%) 1.51%

Additional information

Historical results

Checkout details:

@ctz ctz force-pushed the jbp-nightly-clippy-3 branch from 637a001 to ec1ba67 Compare February 27, 2024 16:31
@ctz ctz force-pushed the jbp-nightly-clippy-3 branch from ec1ba67 to 8de5097 Compare February 27, 2024 16:44
@ctz ctz enabled auto-merge February 27, 2024 16:44
@ctz ctz disabled auto-merge February 27, 2024 16:49
ctz added 6 commits February 27, 2024 16:54
"warning: the item `rustls` is imported redundantly"
"warning: the item `CertificateChain` is imported redundantly"
"warning: the item `SessionId` is imported redundantly"
"warning: you are explicitly cloning with `.map()`"
"warning: the item `rustls` is imported redundantly"
This fixes a wedge of instances of:

```
warning: the item `String` is imported redundantly
  --> rustls/src/msgs/handshake.rs:27:5
   |
27 | use alloc::string::String;
   |     ^^^^^^^^^^^^^^^^^^^^^
```

Where `String` is present from the std prelude when built
for testing.  Like we just did in webpki, _always_ opt-in
to no_std, and then import the std prelude in tests where
necessary.
This is a complete mock for `rustls::client::ClientSessionStore`,
but we don't have tests that use 100% of its abilities.
@ctz ctz force-pushed the jbp-nightly-clippy-3 branch from 8de5097 to ab81ef8 Compare February 27, 2024 16:54
@ctz ctz enabled auto-merge February 27, 2024 17:02
@codecov
Copy link

codecov bot commented Feb 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.98%. Comparing base (64f9742) to head (ab81ef8).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1813   +/-   ##
=======================================
  Coverage   95.98%   95.98%           
=======================================
  Files          84       84           
  Lines       18791    18794    +3     
=======================================
+ Hits        18036    18039    +3     
  Misses        755      755           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ctz ctz added this pull request to the merge queue Feb 27, 2024
Merged via the queue into main with commit 0eab92f Feb 27, 2024
@ctz ctz deleted the jbp-nightly-clippy-3 branch February 27, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants