Update bogo version#1740
Merged
Merged
Conversation
- implement -shim-id option - ignore -ipv6 option - track name change on ALPS test
This exits with BOGO_NACK if an unsupported verification algorithm is requested. That is enough to enable 78 more test cases.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1740 +/- ##
=======================================
Coverage 95.97% 95.97%
=======================================
Files 80 80
Lines 18170 18170
=======================================
Hits 17439 17439
Misses 731 731 ☔ View full report in Codecov by Sentry. |
Benchmark resultsInstruction countsSignificant differencesThere are no significant instruction count differences Other differencesClick to expand
Wall-timeSignificant differencesThere are no significant wall-time differences Other differencesClick to expand
Additional informationCheckout details:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This takes us from https://github.com/rustls/boringssl/tree/b81c2d26009b6cc5159b7a9cbdddfa4ae79defea to https://github.com/rustls/boringssl/tree/586adb914834a953d48fcc7a5d22aeed9d7f53c8, updating the underlying boringssl by about 8 months.
The second commit enables a chunk of extra signature verification tests.
I expect this version has some extra testing around ECH and maybe extension ordering permutation, but I haven't looked into that in detail.