Skip to content

Update bogo version#1740

Merged
cpu merged 2 commits into
mainfrom
jbp-bogo-update
Jan 10, 2024
Merged

Update bogo version#1740
cpu merged 2 commits into
mainfrom
jbp-bogo-update

Conversation

@ctz

@ctz ctz commented Jan 10, 2024

Copy link
Copy Markdown
Member

This takes us from https://github.com/rustls/boringssl/tree/b81c2d26009b6cc5159b7a9cbdddfa4ae79defea to https://github.com/rustls/boringssl/tree/586adb914834a953d48fcc7a5d22aeed9d7f53c8, updating the underlying boringssl by about 8 months.

The second commit enables a chunk of extra signature verification tests.

I expect this version has some extra testing around ECH and maybe extension ordering permutation, but I haven't looked into that in detail.

ctz added 2 commits January 10, 2024 12:08
- implement -shim-id option
- ignore -ipv6 option
- track name change on ALPS test
This exits with BOGO_NACK if an unsupported verification algorithm is
requested.  That is enough to enable 78 more test cases.
@codecov

codecov Bot commented Jan 10, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (25135a0) 95.97% compared to head (a1489a3) 95.97%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1740   +/-   ##
=======================================
  Coverage   95.97%   95.97%           
=======================================
  Files          80       80           
  Lines       18170    18170           
=======================================
  Hits        17439    17439           
  Misses        731      731           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rustls-benchmarking

rustls-benchmarking Bot commented Jan 10, 2024

Copy link
Copy Markdown

Benchmark results

Instruction counts

Significant differences

There are no significant instruction count differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_session_id_aws_lc_rs_1.2_rsa_aes_server 4109774 4057992 -51782 (-1.26%) 3.51%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 8692047 8750980 58933 (0.68%) 1.59%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_server 4623254 4599812 -23442 (-0.51%) 3.60%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_server 12656368 12715873 59505 (0.47%) 0.87%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_client 30907637 30764887 -142750 (-0.46%) 0.66%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 8730545 8690681 -39864 (-0.46%) 1.25%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_server 33643039 33545958 -97081 (-0.29%) 0.47%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_server 33633914 33555254 -78660 (-0.23%) 0.56%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_client 30850872 30915881 65009 (0.21%) 0.63%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_server 33319795 33270777 -49018 (-0.15%) 0.64%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_server 12689742 12706199 16457 (0.13%) 0.93%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_client 31033201 31067404 34203 (0.11%) 0.28%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_client 31047686 31014945 -32741 (-0.11%) 1.01%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_server 91412474 91324125 -88349 (-0.10%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 92453100 92386105 -66995 (-0.07%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 3387755 3389942 2187 (0.06%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 57941944 57977635 35691 (0.06%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_server 57205258 57179106 -26152 (-0.05%) 0.30%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_server 33327228 33312783 -14445 (-0.04%) 0.51%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_client 30877024 30866493 -10531 (-0.03%) 0.47%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_server 12325797 12329471 3674 (0.03%) 0.71%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_client 31047129 31055317 8188 (0.03%) 0.47%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_client 31067589 31062222 -5367 (-0.02%) 0.43%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 3392427 3391849 -578 (-0.02%) 0.38%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_server 57120546 57129864 9318 (0.02%) 0.39%
handshake_no_resume_ring_1.3_ecdsap256_chacha_client 3897993 3897434 -559 (-0.01%) 0.23%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 2046477 2046745 268 (0.01%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_client 42127882 42132296 4414 (0.01%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_client 41966418 41962024 -4394 (-0.01%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_server 43852621 43848096 -4525 (-0.01%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_server 43888601 43893100 4499 (0.01%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_client 42096972 42092747 -4225 (-0.01%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_server 43672442 43668209 -4233 (-0.01%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_client 92457379 92448809 -8570 (-0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_client 4468923 4469279 356 (0.01%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_server 2128713 2128548 -165 (-0.01%) 0.39%
handshake_no_resume_ring_1.3_rsa_chacha_client 4545672 4545974 302 (0.01%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_client 42124201 42126906 2705 (0.01%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 57975846 57972293 -3553 (-0.01%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_client 41907912 41910395 2483 (0.01%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_client 3895222 3895005 -217 (-0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 2049772 2049659 -113 (-0.01%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_server 4373882 4374120 238 (0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_client 3375735 3375910 175 (0.01%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_client 92382738 92387227 4489 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_chacha_server 2131578 2131475 -103 (-0.00%) 0.34%
transfer_no_resume_ring_1.3_ecdsap384_chacha_server 91252739 91257005 4266 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_client 41959513 41957630 -1883 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_client 57952207 57949739 -2468 (-0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 4850626 4850820 194 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_server 57093044 57091169 -1875 (-0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_client 4440792 4440648 -144 (-0.00%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_server 4851221 4851371 150 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 92420782 92418302 -2480 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_server 12250077 12249771 -306 (-0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_client 42090580 42091494 914 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_server 33559605 33558954 -651 (-0.00%) 0.33%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_client 4140753 4140832 79 (0.00%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_client 4696061 4696134 73 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_client 42295055 42294454 -601 (-0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_server 12045772 12045605 -167 (-0.00%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_client 4426618 4426679 61 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_server 12239828 12239993 165 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_server 43911757 43912275 518 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 4855153 4855097 -56 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_client 30863133 30862781 -352 (-0.00%) 0.33%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_client 31061481 31061128 -353 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_client 31258645 31258304 -341 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_client 4535961 4535914 -47 (-0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_client 42095573 42095140 -433 (-0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_client 41919659 41920082 423 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_client 3171571 3171540 -31 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_client 57928383 57927836 -547 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_server 33243263 33243552 289 (0.00%) 0.49%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_server 33300243 33299957 -286 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_client 31238536 31238314 -222 (-0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_server 43668458 43668157 -301 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_client 92371574 92372199 625 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_server 91252441 91252998 557 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_server 43883112 43882864 -248 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_client 92387170 92386658 -512 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_client 35453190 35452994 -196 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_server 33539594 33539417 -177 (-0.00%) 0.49%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_server 33587532 33587373 -159 (-0.00%) 0.26%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_server 33280660 33280508 -152 (-0.00%) 0.36%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_server 33256204 33256351 147 (0.00%) 0.49%
handshake_no_resume_ring_1.3_ecdsap384_aes_server 13736750 13736808 58 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 57182612 57182395 -217 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_server 13740761 13740709 -52 (-0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_server 43923294 43923459 165 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_server 43951917 43951766 -151 (-0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_client 42329864 42329719 -145 (-0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_server 43596251 43596388 137 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_server 43602332 43602468 136 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_server 57088338 57088160 -178 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_client 57998259 57998102 -157 (-0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_server 43664641 43664530 -111 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_server 57088557 57088680 123 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_server 33534597 33534529 -68 (-0.00%) 0.41%
handshake_no_resume_ring_1.3_ecdsap384_aes_client 35449977 35449912 -65 (-0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_server 43606069 43606145 76 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 57183183 57183096 -87 (-0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_client 57812278 57812359 81 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_client 68391997 68391902 -95 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_server 91257446 91257564 118 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 91351977 91351867 -110 (-0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_server 56973797 56973740 -57 (-0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_client 42141978 42142017 39 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_client 31041471 31041454 -17 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 91372764 91372806 42 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_client 57947368 57947344 -24 (-0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_client 3386337 3386336 -1 (-0.00%) 0.20%

Wall-time

Significant differences

There are no significant wall-time differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 484.65 µs 487.49 µs 2.84 µs (0.59%) 2.17%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes 4.92 ms 4.94 ms 0.03 ms (0.54%) 5.79%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes 5.83 ms 5.86 ms 0.03 ms (0.53%) 5.38%
handshake_no_resume_ring_1.3_ecdsap256_chacha 504.55 µs 507.08 µs 2.54 µs (0.50%) 2.23%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes 5.82 ms 5.84 ms 0.03 ms (0.45%) 4.61%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes 5.67 ms 5.69 ms 0.02 ms (0.42%) 5.08%
transfer_no_resume_ring_1.2_rsa_aes 7.17 ms 7.20 ms 0.03 ms (0.40%) 3.78%
handshake_tickets_aws_lc_rs_1.2_rsa_aes 2.24 ms 2.25 ms 0.01 ms (0.35%) 1.96%
handshake_no_resume_ring_1.2_rsa_aes 1.07 ms 1.07 ms 0.00 ms (0.30%) 1.00%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha 5.40 ms 5.38 ms -0.02 ms (-0.29%) 1.92%
transfer_no_resume_ring_1.3_rsa_aes 7.29 ms 7.31 ms 0.02 ms (0.29%) 4.21%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha 14.34 ms 14.37 ms 0.03 ms (0.22%) 2.30%
handshake_no_resume_ring_1.3_ecdsap256_aes 506.66 µs 507.75 µs 1.09 µs (0.21%) 3.50%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes 485.50 µs 486.53 µs 1.02 µs (0.21%) 3.78%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 1.22 ms 1.23 ms 0.00 ms (0.20%) 1.00%
handshake_session_id_ring_1.2_rsa_aes 1.70 ms 1.69 ms -0.00 ms (-0.20%) 2.10%
handshake_tickets_ring_1.3_rsa_aes 7.49 ms 7.51 ms 0.01 ms (0.20%) 1.32%
handshake_no_resume_ring_1.3_ecdsap384_aes 3.61 ms 3.62 ms 0.01 ms (0.19%) 1.01%
transfer_no_resume_ring_1.3_ecdsap384_aes 9.83 ms 9.84 ms 0.02 ms (0.19%) 3.09%
handshake_tickets_ring_1.3_ecdsap384_aes 9.96 ms 9.98 ms 0.02 ms (0.18%) 1.24%
handshake_tickets_ring_1.3_rsa_chacha 7.45 ms 7.46 ms 0.01 ms (0.17%) 1.58%
handshake_session_id_aws_lc_rs_1.3_rsa_aes 6.37 ms 6.36 ms -0.01 ms (-0.17%) 1.25%
transfer_no_resume_ring_1.3_ecdsap256_aes 6.72 ms 6.73 ms 0.01 ms (0.17%) 3.90%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 13.43 ms 13.45 ms 0.02 ms (0.17%) 2.23%
handshake_session_id_aws_lc_rs_1.2_rsa_aes 2.07 ms 2.07 ms 0.00 ms (0.16%) 1.76%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha 6.36 ms 6.35 ms -0.01 ms (-0.16%) 1.14%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha 6.13 ms 6.12 ms -0.01 ms (-0.16%) 1.69%
handshake_session_id_ring_1.3_rsa_aes 7.49 ms 7.50 ms 0.01 ms (0.15%) 1.00%
handshake_session_id_ring_1.3_ecdsap384_chacha 9.92 ms 9.93 ms 0.01 ms (0.15%) 1.47%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes 6.14 ms 6.14 ms -0.01 ms (-0.14%) 1.59%
transfer_no_resume_ring_1.3_ecdsap384_chacha 16.52 ms 16.54 ms 0.02 ms (0.14%) 1.96%
handshake_tickets_ring_1.3_ecdsap384_chacha 9.93 ms 9.94 ms 0.01 ms (0.13%) 1.21%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 14.17 ms 14.19 ms 0.02 ms (0.13%) 1.60%
handshake_tickets_ring_1.2_rsa_aes 1.78 ms 1.78 ms 0.00 ms (0.13%) 2.00%
transfer_no_resume_ring_1.3_rsa_chacha 13.99 ms 14.00 ms 0.02 ms (0.13%) 2.36%
handshake_session_id_ring_1.3_rsa_chacha 7.44 ms 7.45 ms 0.01 ms (0.12%) 1.35%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes 5.40 ms 5.39 ms -0.01 ms (-0.12%) 2.12%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha 1.39 ms 1.39 ms 0.00 ms (0.11%) 1.24%
handshake_tickets_aws_lc_rs_1.3_rsa_aes 6.41 ms 6.41 ms -0.01 ms (-0.11%) 1.08%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes 5.43 ms 5.43 ms -0.01 ms (-0.10%) 1.54%
handshake_no_resume_ring_1.3_ecdsap384_chacha 3.61 ms 3.62 ms 0.00 ms (0.10%) 1.06%
handshake_session_id_ring_1.3_ecdsap384_aes 9.96 ms 9.97 ms 0.01 ms (0.09%) 1.40%
handshake_tickets_ring_1.3_ecdsap256_aes 6.86 ms 6.87 ms 0.00 ms (0.07%) 1.71%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes 1.40 ms 1.40 ms 0.00 ms (0.07%) 1.20%
handshake_session_id_ring_1.3_ecdsap256_aes 6.86 ms 6.87 ms 0.00 ms (0.05%) 1.82%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes 1.23 ms 1.23 ms -0.00 ms (-0.05%) 1.00%
transfer_no_resume_ring_1.3_ecdsap256_chacha 13.42 ms 13.42 ms 0.01 ms (0.05%) 2.70%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes 1.35 ms 1.35 ms 0.00 ms (0.04%) 1.02%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha 6.15 ms 6.16 ms 0.00 ms (0.04%) 1.61%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes 6.19 ms 6.19 ms -0.00 ms (-0.04%) 1.99%
handshake_no_resume_ring_1.3_rsa_aes 1.08 ms 1.08 ms 0.00 ms (0.04%) 1.33%
handshake_tickets_ring_1.3_ecdsap256_chacha 6.83 ms 6.83 ms 0.00 ms (0.04%) 1.65%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha 6.39 ms 6.39 ms -0.00 ms (-0.03%) 1.00%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha 5.41 ms 5.41 ms -0.00 ms (-0.02%) 1.41%
handshake_no_resume_ring_1.3_rsa_chacha 1.08 ms 1.08 ms -0.00 ms (-0.01%) 1.29%
handshake_session_id_ring_1.3_ecdsap256_chacha 6.83 ms 6.83 ms -0.00 ms (-0.00%) 1.27%

Additional information

Historical results

Checkout details:

@djc djc left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@cpu cpu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@cpu
cpu added this pull request to the merge queue Jan 10, 2024
Merged via the queue into main with commit 432ceca Jan 10, 2024
@cpu
cpu deleted the jbp-bogo-update branch January 10, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants