Skip to content

Clean up rustls::internal exports#1544

Merged
ctz merged 12 commits intomainfrom
jbp-clean-up-internal
Oct 19, 2023
Merged

Clean up rustls::internal exports#1544
ctz merged 12 commits intomainfrom
jbp-clean-up-internal

Conversation

@ctz
Copy link
Member

@ctz ctz commented Oct 18, 2023

This is a tentative attempt to clean this up, starting by being precise about what parts are needed to run the existing tests we have. That has uncovered a few instances of unused code that were previously pub.

@codecov
Copy link

codecov bot commented Oct 18, 2023 •
edited
Loading

Codecov Report

Merging #1544 (e5a2d42) into main (3b8a7c3) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1544      +/-   ##
==========================================
+ Coverage   96.46%   96.49%   +0.02%     
==========================================
  Files          74       74              
  Lines       15107    15110       +3     
==========================================
+ Hits        14573    14580       +7     
+ Misses        534      530       -4
Files Coverage Δ
rustls/src/client/tls12.rs 98.53% <100.00%> (ø)
rustls/src/enums.rs 100.00% <ø> (ø)
rustls/src/msgs/base.rs 92.78% <100.00%> (+2.78%) ⬆️
rustls/src/msgs/codec.rs 98.75% <100.00%> (ø)
rustls/src/msgs/deframer.rs 97.98% <100.00%> (+0.19%) ⬆️
rustls/src/msgs/enums.rs 100.00% <ø> (ø)
rustls/src/msgs/fragmenter.rs 100.00% <100.00%> (ø)
rustls/src/msgs/handshake.rs 98.10% <100.00%> (+<0.01%) ⬆️
rustls/src/msgs/handshake_test.rs 99.60% <100.00%> (+<0.01%) ⬆️
rustls/src/msgs/macros.rs 93.02% <100.00%> (ø)
... and 3 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ctz ctz force-pushed the jbp-clean-up-internal branch from f3b70b1 to 145b19b Compare October 19, 2023 10:27
ctz added 2 commits October 19, 2023 11:35
@ctz
Rework enum_builder macro
f83457d 
The goal of this is to make the visibility of the type it produces
explicit rather than implicit.

As a side effect, it makes the declarations a bit less odd-looking.
@ctz
Make visibility explicit in wrapped_payload macro
a930062
@ctz ctz force-pushed the jbp-clean-up-internal branch from 145b19b to 2735c23 Compare October 19, 2023 10:42
@ctz ctz marked this pull request as ready for review October 19, 2023 10:48
@ctz ctz mentioned this pull request Oct 19, 2023
Merged
cpu
cpu approved these changes Oct 19, 2023
View reviewed changes
Copy link
Member

@cpu cpu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice clean-up!

@ctz ctz force-pushed the jbp-clean-up-internal branch from 2735c23 to e5a2d42 Compare October 19, 2023 14:55
@ctz ctz added this pull request to the merge queue Oct 19, 2023
Merged via the queue into main with commit 1fbb608 Oct 19, 2023
@ctz ctz deleted the jbp-clean-up-internal branch October 19, 2023 15:15
@XOR-op XOR-op mentioned this pull request Nov 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cpu cpu cpu approved these changes

@djc djc djc approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ctz @djc @cpu