Conversation
|
(maybe this big table isn't warranted in the release notes, maybe the README instead?) |
|
Release notes LGTM.
Maybe hyperlink to https://github.com/rustls/pki-types or https://docs.rs/rustls-pki-types/latest/rustls_pki_types/ ?
I don't think there's a big disadvantage to having it in the release notes (or both places!). |
It would probably be a good idea to include a paragraph in the README about the future of this crate/API in either case |
bdfc6ef to
7c48b63
Compare
7c48b63 to
658f52c
Compare
Release notes:
The main function of this crate has been incorporated into rustls-pki-types. 2.2.0 maintains the existing public API for this crate, on top of this new implementation. This drops the dependency on the
base64crate, and allows for constant-time decoding of private keys.This crate will continue to exist in its current form, but it is somewhat unlikely that the API will be extended from its current state.
Should you wish to migrate to using the new
rustls-pki-typesPEM APIs directly, here is a rough cheat-sheet:CertificateDeriteratorrustls_pemfile::certs(io::BufRead)➡️
CertificateDer::pem_reader_iter(io::Read)PrivateKeyDerrustls_pemfile::private_key(io::BufRead)➡️
PrivateKeyDer::from_pem_reader(io::Read)CertificateSigningRequestDerrustls_pemfile::csr(io::BufRead)➡️
CertificateSigningRequestDer::from_pem_reader(io::Read)CertificateRevocationListDeriteratorrustls_pemfile::crls(io::BufRead)➡️
CertificateRevocationListDer::pem_reader_iter(io::Read)PrivatePkcs1KeyDeriteratorrustls_pemfile::rsa_private_keys(io::BufRead)➡️
PrivatePkcs1KeyDer::pem_reader_iter(io::Read)PrivatePkcs8KeyDeriteratorrustls_pemfile::pkcs8_private_keys(io::BufRead)➡️
PrivatePkcs8KeyDer::pem_reader_iter(io::Read)PrivateSec1KeyDeriteratorrustls_pemfile::ec_private_keys(io::BufRead)➡️
PrivateSec1KeyDer::pem_reader_iter(io::Read)SubjectPublicKeyInfoDeriteratorrustls_pemfile::public_keys(io::BufRead)➡️
SubjectPublicKeyInfoDer::pem_reader_iter(io::Read)