This repository was archived by the owner on Aug 19, 2025. It is now read-only.
Conversation
cpu
reviewed
Sep 18, 2024
ctz
force-pushed
the
jbp-use-pki-types-pem
branch
from
f44babd to
77351f4
Compare
Member
Author
Now |
djc
approved these changes
Sep 25, 2024
Member
djc
left a comment
djc
left a comment
There was a problem hiding this comment.
Okay, this seems to work out well?
I'm assuming you'll just squash all the commits here?
ctz
force-pushed
the
jbp-use-pki-types-pem
branch
from
77351f4 to
1e62bbb
Compare
(with rustls's config)
ctz
force-pushed
the
jbp-use-pki-types-pem
branch
from
66eff48 to
6a0f0fe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was hoping to rely on cargo-semver-checks here to check for API regressions, alas obi1kenobi/cargo-semver-checks#609 means this is not possible.