This repository was archived by the owner on Aug 19, 2025. It is now read-only.
Merged
Conversation
cpu
reviewed
Aug 1, 2024
Member
cpu
left a comment
cpu
left a comment
There was a problem hiding this comment.
Seems reasonable, but I had a couple of questions.
| @@ -0,0 +1,14 @@ | |||
| -----BEGIN PUBLIC KEY----- | |||
Member
There was a problem hiding this comment.
Out of curiosity, how was this generated?
Contributor
Author
There was a problem hiding this comment.
Using openssl rsa -in private_key.pem -pubout -out public_key.pem
cpu
approved these changes
Aug 1, 2024
holodorum
force-pushed
the
read_public_keys
branch
from
d59dad1 to
527921f
Compare
djc
approved these changes
Aug 3, 2024
Member
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR supports reading SPKI from a pemfile, which aids the implementation of RFC 7250 (Raw Public Key support) in rustls.
Main changes:
public_key()andpublic_keys(). Thepublic_key()function returns the firstSubjectPublicKeyInfoDerit encounters in a pemfile, whilepublic_keys()returns an iterator over all the public keys within a pemfile. Does it ever happen that we have a pemfile with multiple public keys? If not I'll remove this function.SubjectPublicKeyInfoDerpki-types is bumped up from version 1.3 to 1.7.Contributors:
This PR is made in collaboration with @aochagavia.