Add function to check if environment variables are configured corretly, fixes #7#9
Merged
alexcrichton merged 1 commit intorustls:masterfrom Jul 9, 2018
Merged
Conversation
Collaborator
|
Looks good to me, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds basic functionality in the crate to check whether the OpenSSL environment variables are configured and valid. This allows basic checking
The function
has_ssl_cert_env_vars()has been added to determine whether any certificates will be found by OpenSSL through some basic environment variable checking.The function
init_ssl_cert_env_vars()now returns aboolto indicate whether any certificates were found while probing.I've created constants for the environment variable keys to minimize duplication.
Note though, that these basic checks should be run before initializing OpenSSL, and that they are simple directory checks. It does currently not seem possible to actually check whehter the
opensslcrate is properly using these certificates, as it does not provide an interface for that.Fixes #7
What do you think?