Skip to content

Comments

feat: add openharmony platform preset certs folder#42

Merged
djc merged 1 commit intorustls:mainfrom
richerfu:feat-ohos
Jan 3, 2026
Merged

feat: add openharmony platform preset certs folder#42
djc merged 1 commit intorustls:mainfrom
richerfu:feat-ohos

Conversation

@richerfu
Copy link
Contributor

@richerfu richerfu commented Nov 28, 2025

follow #38 cc @djc

Also fix #29

@djc
Copy link
Member

djc commented Nov 28, 2025

Doesn't OpenHarmony have its own target_os?

@richerfu
Copy link
Contributor Author

Doesn't OpenHarmony have its own target_os?

No.. only target_env=ohos Should we use it?

@djc
Copy link
Member

djc commented Nov 28, 2025

Doesn't OpenHarmony have its own target_os?

No.. only target_env=ohos Should we use it?

I guess if that makes all the cfgs more complicated, it might not be worth it.

Please rebase on top of current main.

@djc
Copy link
Member

djc commented Nov 28, 2025

(Please rebase and squash all your changes into a single commit.)

@djc djc changed the base branch from split to main November 28, 2025 09:32
Copy link
Member

@djc djc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay to me, let's see what other folks think.

@djc djc requested review from cpu and ctz November 28, 2025 09:41
@richerfu
Copy link
Contributor Author

@cpu @ctz Hi can we proceed with this pull request? Thanks :)

Copy link
Member

@cpu cpu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the ping, apologies for letting this sit. The diff looks OK to me.

@djc djc added this pull request to the merge queue Jan 1, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Jan 1, 2026
@djc djc added this pull request to the merge queue Jan 1, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Jan 1, 2026
@djc djc added this pull request to the merge queue Jan 3, 2026
@djc djc mentioned this pull request Jan 3, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Jan 3, 2026
@djc djc added this pull request to the merge queue Jan 3, 2026
Merged via the queue into rustls:main with commit 5e18d53 Jan 3, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bad probe result on OpenHarmonyOS

3 participants