feat(helm): add existingSecret handling and support for extra manifests #992
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@babs Thanks for your contribution. /LGTM @loverustfs already tested on k3s and worked fine. |
loverustfs
force-pushed
the
feat/helm-secret-extraobject
branch
from
af36c44 to
187a65c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Related Issues
N/A
Summary of Changes
Add two features to the Helm chart:
secret.existingSecret: allows referencing a pre-existing Kubernetes secret instead of creating oneextraManifests: allows deploying additional arbitrary Kubernetes resources alongside the chart (like externalSecret manifests)Checklist
make pre-commitImpact