console: add version_handler and improve comments
#975
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add `version_handler` endpoint to serve console version metadata as JSON (version, version_info, date). Returns 200 when config is initialized and 500 if not. - Clarify and expand documentation comments and logging in `rustfs/src/admin/console.rs`. - Minor robustness and serialization error handling improvements.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a new version_handler endpoint to serve console version metadata and improves code documentation throughout the console module.
- Added
/rustfs/console/versionendpoint that returns version, version_info, and date as JSON - Standardized documentation format using
# Argumentsand# Returnssections - Added startup time logging for both console and API modes
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| rustfs/src/server/http.rs | Added startup time logging with formatted timestamps for both console and standard API modes |
| rustfs/src/admin/console.rs | Added version_handler endpoint, improved documentation comments with standardized format, updated function visibility, and added route registration for the new version endpoint |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
version_handlerendpoint to serve console version metadata as JSON (version, version_info, date). Returns 200 when config is initialized and 500 if not.rustfs/src/admin/console.rs.Type of Change
Related Issues
Summary of Changes
Checklist
make pre-commitImpact
Additional Notes
Thank you for your contribution! Please ensure your PR follows the community standards (CODE_OF_CONDUCT.md) and sign the CLA if this is your first contribution.