upgrade crate version and improve heal config #963
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/dependencies-1126 * 'main' of github.com:rustfs/rustfs: Modify readme
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR performs a refactoring to improve heal configuration management and upgrades several crate dependencies to their latest versions.
Key Changes:
- Introduces centralized heal configuration constants with environment variable support for queue size, intervals, timeouts, and concurrency limits
- Upgrades dependencies: rmcp (0.9.1 → 0.10.0), libc (0.2.177 → 0.2.178), uuid (1.18.1 → 1.19.0), zerocopy (0.8.30 → 0.8.31)
- Comments out object name correction/auto-healing logic in set_disk.rs
Reviewed changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| crates/config/src/constants/heal.rs | Adds new heal configuration constants with comprehensive documentation for environment variables and default values |
| crates/config/src/lib.rs | Exports the new heal module for public use |
| crates/config/src/constants/mod.rs | Declares the heal submodule |
| crates/ahm/src/heal/manager.rs | Updates HealConfig default implementation to read from environment variables using the new constants |
| crates/ahm/Cargo.toml | Adds rustfs-config and rustfs-utils dependencies for configuration management |
| crates/ecstore/src/set_disk.rs | Comments out the object name correction logic (47 lines) |
| scripts/run.sh | Adds RUSTFS_HEAL_QUEUE_SIZE environment variable export |
| Cargo.toml | Updates rmcp, libc, and uuid dependency versions |
| Cargo.lock | Reflects resolved dependency updates including transitive dependencies |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 8 out of 9 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…s/rustfs into dependabot/cargo/dependencies-1126 * 'dependabot/cargo/dependencies-1126' of github.com:rustfs/rustfs: Fix Admin Heal API and Add Pagination Support for Large Buckets (#933)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Related Issues
Summary of Changes
Checklist
make pre-commitImpact
Additional Notes
Thank you for your contribution! Please ensure your PR follows the community standards (CODE_OF_CONDUCT.md) and sign the CLA if this is your first contribution.