Updated RUSTFS_VOLUMES to fix pod crashing #922
Conversation
1. Removed .rustfs.svc.cluster.local as all pods for statefulset are running in the same namespace 2. used "rustfs.fullname" as it's used in statefulset services and statefull set names
|
|
|
Really appreciate the help! We're going to review this and follow up with you. |
There was a problem hiding this comment.
Pull request overview
This PR fixes pod crashing issues caused by incorrect service and pod naming in the RUSTFS_VOLUMES configuration for distributed mode deployments.
- Replaced hardcoded service/pod names with templated
rustfs.fullnamehelper function - Removed unnecessary
.rustfs.svc.cluster.localnamespace suffix for intra-namespace communication - Applied fixes to both 4-replica and 16-replica configurations
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
majinghe
left a comment
majinghe
left a comment
There was a problem hiding this comment.
@serhiynovos Thanks for you contribution. I think FQDN is better?
|
@majinghe if all pods within one namespace it's not necessary also svc.local.cluster is not constant. K8s allow to use different values for it |
|
/LGTM @loverustfs @houseme |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@serhiynovos Thank you very much. |
|
This part should be moved to template helper and added possibility to override with |
|
6 participants
Type of Change
Related Issues
Once I installed helm chart I noticed that all pods were crashing. Here I noticed a few issues
rustfsnamespacerustfs.fullnameSummary of Changes
As all pods are running in the same namespace I left only headless service name + pod name. Updated pod name and service name according to names defined for statefulset and services
Checklist
make pre-commit