remove debug #912
Merged
remove debug #912
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Contributor
|
Really appreciate the help! We're going to review this and follow up with you. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes accidentally committed debug logging statements that were added during development. The changes clean up temporary debugging code prefixed with "CLAUDE DEBUG" that was inadvertently included in the repository.
- Removed debug println! and info! logging statements from KMS initialization
- Cleaned up debug logging from KMS service manager methods
- Removed debug tracing statements from disk operations
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| rustfs/src/main.rs | Removed debug logging from init_kms_system function |
| crates/kms/src/service_manager.rs | Removed debug logging from configure(), start(), and get_global_encryption_service() functions; simplified logic in get_global_encryption_service() |
| crates/ecstore/src/disk/local.rs | Removed debug tracing statements from rename_data function |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Related Issues
Summary of Changes
Started using quick start rustfs and what was wtf is claude code infering in my docker container and how and then realized it's commited inside the repo 😂
Checklist
make pre-commitImpact
Additional Notes
Thank you for your contribution! Please ensure your PR follows the community standards (CODE_OF_CONDUCT.md) and sign the CLA if this is your first contribution.