add standalone mode support #881
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Add standalone mode support, just one pod one pvc. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request adds standalone mode support to the RustFS Helm chart, allowing users to deploy RustFS either as a single-pod standalone instance or as a multi-pod distributed cluster. The changes introduce mode configuration options and create appropriate Kubernetes resources for each deployment type.
Key changes:
- Added mode configuration (
mode.standalone.enabledandmode.distributed.enabled) to control deployment type - Created new Deployment and PVC templates for standalone mode
- Updated security contexts to use UID/GID 10001 instead of 1000 across all components
- Modified existing templates to conditionally deploy based on selected mode
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| helm/rustfs/values.yaml | Added mode configuration, updated security contexts to use UID 10001, changed image pull policy and tag defaults |
| helm/rustfs/tls/tls.key | Updated placeholder text for private key |
| helm/rustfs/tls/tls.crt | Updated placeholder text for certificate |
| helm/rustfs/templates/statefulset.yaml | Wrapped in distributed mode conditional, updated security contexts and user IDs, converted logs from emptyDir to PVC |
| helm/rustfs/templates/service.yaml | Added conditional deployment for headless service based on distributed mode |
| helm/rustfs/templates/pvc.yaml | New file defining PersistentVolumeClaims for standalone mode |
| helm/rustfs/templates/deployment.yaml | New file defining Deployment resource for standalone mode |
| helm/rustfs/templates/configmap.yaml | Added conditional RUSTFS_VOLUMES configuration based on deployment mode |
| helm/README.md | Updated documentation to describe standalone and distributed modes, updated version requirement to 1.0.0-alpha.68 |
| Dockerfile | Updated user and group IDs from 1000 to 10001 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Related Issues
Summary of Changes
Checklist
make pre-commitImpact
Additional Notes
Thank you for your contribution! Please ensure your PR follows the community standards (CODE_OF_CONDUCT.md) and sign the CLA if this is your first contribution.