Fix audit system state transition with empty targets #854
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Related Issues
Summary of Changes
Problem
The audit system currently transitions to
AuditSystemState::Startingimmediately upon entering thestart()method, before validating that any targets exist. This causes a brief state inconsistency when the configuration contains no enabled targets.Solution
This PR modifies the state machine logic to:
Startingstate if targets existOk(())and keepStoppedstate when no targets are foundChanges
crates/audit/src/system.rs*state = AuditSystemState::Starting) after target creationtargets.is_empty()Testing
Stoppedstate when no targets configuredImpact
Checklist
make pre-commitImpact
Additional Notes
Thank you for your contribution! Please ensure your PR follows the community standards (CODE_OF_CONDUCT.md) and sign the CLA if this is your first contribution.