fix: modify logger from warn to info #842
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors error logging in the metacache_set module and updates several dependencies. While the title focuses on logger changes, the PR includes dependency updates as part of a broader refactoring effort.
Key changes:
- Downgrades walk directory error logging from
error!toinfo!level when fallback mechanism is available - Updates four dependencies:
quick-xml(0.38.3→0.38.4),crc-fast(1.3.0→1.6.0),google-cloud-storage(1.2.0→1.3.0), andgoogle-cloud-auth(1.1.0→1.1.1)
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| crates/ecstore/src/cache_value/metacache_set.rs | Changes error logging level from error! to info! for walk_dir failures with fallback recovery; adds info to tracing imports |
| Cargo.toml | Updates versions for quick-xml, crc-fast, google-cloud-storage, and google-cloud-auth dependencies |
| Cargo.lock | Reflects dependency version updates and their transitive dependencies (google-cloud-gax, google-cloud-gax-internal) with updated checksums |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Related Issues
Summary of Changes
Checklist
make pre-commitImpact
Additional Notes
Thank you for your contribution! Please ensure your PR follows the community standards (CODE_OF_CONDUCT.md) and sign the CLA if this is your first contribution.