Type of Change

• New Feature
• Bug Fix
• Documentation
• Performance Improvement
• Test/CI
• Refactor
• Other:

Related Issues

Summary of Changes

Summary

This PR introduces a comprehensive refactoring of the audit logging and event notification systems within the ecfs.rs storage implementation. The primary goal is to enhance code quality, reduce redundancy, and improve maintainability by centralizing common logic into a new, unified OperationHelper.

Key Changes

1. Introduced OperationHelper:

   • A new OperationHelper struct has been created in its own module (rustfs/src/storage/helper.rs).
   • This helper now manages both the AuditEntryBuilder for audit logs and the EventArgsBuilder for event notifications.
   • It leverages the RAII pattern: its Drop implementation automatically dispatches logs and (on success) notifications, simplifying the end of every S3 operation method.

2. Refactored ecfs.rs:

   • Replaced all instances of the old AuditHelper and manual tokio::spawn calls for notifier_global::notify with the new OperationHelper.
   • S3 methods like put_object, create_bucket, and delete_object are now cleaner and more focused on their core logic.
   • The construction of audit and event data is now more expressive, using a fluent, chainable API (e.g., helper.object(info).version_id(id)).

3. Enhanced delete_objects Logic:

   • For the special case of delete_objects, which requires multiple event notifications per API call, the OperationHelper is now used with a new suppress_event() method.
   • This allows the helper to handle the single audit log for the entire operation while letting the delete_objects function manage the manual, per-object event notifications. This maintains a clear separation of responsibilities.

4. Improved notify Crate API:

   • The notify crate was improved by replacing the stateless Notifier struct with a direct notifier_global module, simplifying the public API.
   • EventArgsBuilder was enhanced with a full set of builder methods, making event creation safer and more readable.
   • Error handling was made more granular with the introduction of a LifecycleError enum.

Benefits

• Reduced Boilerplate: Eliminates repetitive code for building and dispatching logs/events at the end of each S3 function.
• Increased Robustness: The RAII pattern ensures that logging and notifications are handled correctly, even in functions with multiple return paths (e.g., using the ? operator).
• Improved Readability: S3 operation logic is now cleaner and easier to follow, as the cross-cutting concerns of auditing and notifying are abstracted away.
• Better Maintainability: Future changes to logging or notification logic can be made in one central place (OperationHelper) instead of across dozens of methods.

Verification

All existing unit and integration tests pass. The following commands were run successfully:

• cargo fmt --all --check
• cargo clippy --all-targets --all-features -- -D warnings
• cargo test --workspace --exclude e2e_test

This refactoring lays a solid foundation for more maintainable and robust S3 operation implementations.

Checklist

• I have read and followed the CONTRIBUTING.md guidelines
• Passed make pre-commit
• Added/updated necessary tests
• Documentation updated (if needed)
• CI/CD passed (if applicable)

Impact

• Breaking change (compatibility)
• Requires doc/config/deployment update
• Other impact:

Additional Notes

Thank you for your contribution! Please ensure your PR follows the community standards (CODE_OF_CONDUCT.md) and sign the CLA if this is your first contribution.