improve code for logger #822
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances logging configuration and observability features to better support production and development environments, with conditional logging behavior based on environment settings.
- Introduces environment-aware logging with separate behaviors for production vs development environments
- Adds helper functions
is_production_environment()andis_develop_environment()to check runtime environment - Enhances flexi_logger configuration with UTC timestamps, append mode, and JSON feature support
Reviewed Changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| scripts/run.sh | Disables stdout logging and enables file-based logging with a specified directory for production-like configurations |
| rustfs/src/server/runtime.rs | Makes Tokio runtime parameter printing conditional on non-production environments |
| crates/obs/src/telemetry.rs | Suppresses warning messages in production and adds stdout formatting, append mode, and UTC timestamp configuration |
| crates/obs/src/lib.rs | Changes from selective exports to wildcard export of config module items for broader API surface |
| crates/obs/src/config.rs | Adds environment detection helper functions and basic tests for configuration defaults |
| Cargo.toml | Adds "json" feature to flexi_logger for JSON formatting support |
| Cargo.lock | Updates transitive dependencies (block-buffer, cc) as a result of dependency resolution |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Related Issues
Summary of Changes
Checklist
make pre-commitImpact
Additional Notes
Thank you for your contribution! Please ensure your PR follows the community standards (CODE_OF_CONDUCT.md) and sign the CLA if this is your first contribution.