Add default storage class to ListObjectsV2 #765
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for storage class information to the object metadata system. The implementation extracts storage class information from object metadata and propagates it through the system to be returned in S3 API responses.
Key Changes:
- Added
storage_classfield toObjectInfostruct to store storage class information - Modified
ObjectInfo::from_file_infoto extract storage class from metadata, defaulting to "STANDARD" - Updated S3
list_objects_v2response to include storage class information
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| crates/ecstore/src/store_api.rs | Added storage_class field to ObjectInfo struct, updated Clone implementation, and implemented extraction of storage class from metadata with default to STANDARD |
| rustfs/src/storage/ecfs.rs | Updated S3 list_objects_v2 response to include storage class from ObjectInfo |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #764
Type of Change
Related Issues
#764
Summary of Changes
Adds storage class to ListObjectsV2
Checklist
make pre-commitNotes:
Based on #763 due to linter errors that would otherwise prevent CI pass