Skip to content

fix: when the error returned by make_bucket is BucketExists, replace … #735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
loverustfs merged 3 commits into from
Oct 28, 2025
Merged

fix: when the error returned by make_bucket is BucketExists, replace … #735

loverustfs merged 3 commits into from
Oct 28, 2025

Conversation

@shiroleeee
Copy link
Contributor

@shiroleeee shiroleeee commented Oct 27, 2025 •
edited
Loading

…BucketAlreadyExists with BucketAlreadyOwnedByYou (#719)

Type of Change

  • New Feature
  • Bug Fix
  • Documentation
  • Performance Improvement
  • Test/CI
  • Refactor
  • Other:

Related Issues

Summary of Changes

Checklist

  • I have read and followed the CONTRIBUTING.md guidelines
  • Passed make pre-commit
  • Added/updated necessary tests
  • Documentation updated (if needed)
  • CI/CD passed (if applicable)

Impact

  • Breaking change (compatibility)
  • Requires doc/config/deployment update
  • Other impact:

Additional Notes

Thank you for your contribution! Please ensure your PR follows the community standards (CODE_OF_CONDUCT.md) and sign the CLA if this is your first contribution.

@shiroleeee
fix: when the error returned by make_bucket is BucketExists, replace …
90aa600 
…BucketAlreadyExists with BucketAlreadyOwnedByYou (rustfs#719)
@genedna genedna requested a review from Copilot October 28, 2025 01:23
Copilot AI reviewed Oct 28, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the S3 error code mapping for bucket creation conflicts. When a bucket already exists during creation, the error code is changed from BucketAlreadyExists to BucketAlreadyOwnedByYou to properly align with S3 API semantics.

  • Changes the S3 error code returned when attempting to create a bucket that already exists

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@shiroleeee
test: In the test_api_error_from_storage_error_mappings test method, …
c8ccded 
…modify the corresponding mapping relationships
@LyndonXiao
Copy link

LyndonXiao commented Oct 28, 2025

why？

@shiroleeee
Copy link
Contributor Author

shiroleeee commented Oct 28, 2025

BucketAlreadyExists: The name of the bucket you are trying to create is already in use by another account.
BucketAlreadyOwnedByYou: The name of the bucket you are trying to create has already been created by your own account.

For Rclone, when S3 returns BucketAlreadyOwnedByYou, it will directly use the existing bucket. If BucketAlreadyExists is returned, it will throw an error, similar to what happened in #719.

@loverustfs loverustfs merged commit d2ced23 into rustfs:main Oct 28, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@shiroleeee @LyndonXiao @loverustfs @weisd