improve code for metrics and switch tokio-tar to astral-tokio-tar #705
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR improves metrics handling by migrating from the legacy tracing-based metrics API to the standard metrics crate API, and replaces the tokio-tar dependency with astral-tokio-tar. The changes also include reorganizing workspace dependencies for better clarity and updating test file comments from Chinese to English.
- Refactored metrics instrumentation to use the
metricscrate's standard API instead of tracing macros - Replaced
tokio-tarwithastral-tokio-taracross the workspace - Reorganized and categorized workspace dependencies in Cargo.toml files
Reviewed Changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| rustfs/src/server/http.rs | Updated metrics calls from tracing-based to metrics crate API (counter! and histogram! macros) |
| rustfs/Cargo.toml | Replaced tokio-tar with astral-tokio-tar and reorganized dependencies into logical groups |
| crates/zip/src/lib.rs | Reordered imports (cosmetic change) |
| crates/zip/Cargo.toml | Replaced tokio-tar with astral-tokio-tar |
| crates/e2e_test/src/kms/multipart_encryption_test.rs | Translated Chinese comments to English |
| crates/e2e_test/src/kms/kms_vault_test.rs | Updated md5::compute import to use explicit function name |
| crates/e2e_test/src/kms/kms_edge_cases_test.rs | Updated md5::compute import to use explicit function name |
| crates/e2e_test/src/kms/kms_comprehensive_test.rs | Translated Chinese comments to English |
| Cargo.toml | Replaced tokio-tar with astral-tokio-tar and reorganized workspace dependencies with category comments |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Related Issues
#698
Summary of Changes
Checklist
make pre-commitImpact
Additional Notes
Thank you for your contribution! Please ensure your PR follows the community standards (CODE_OF_CONDUCT.md) and sign the CLA if this is your first contribution.