-
Notifications
You must be signed in to change notification settings - Fork 759
chore: bump dependencies, add metrics support, remove DNS resolver #699
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF ScorecardScorecard details
Scanned Files
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes the custom DNS resolver implementation and introduces metrics support while bumping several dependencies. The custom DNS resolver relied on the hickory-resolver and moka crates, which are being removed. Metrics instrumentation is added via the metrics crate to track S3 operations and API requests.
Key changes:
- Custom DNS resolver code commented out; system DNS resolution now used as fallback
- Metrics collection added for bucket operations and HTTP requests using the
metricscrate - Dependency updates including
clap,jsonwebtoken,rmcp,rust-embed, andrustls
Reviewed Changes
Copilot reviewed 14 out of 15 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| rustfs/src/storage/ecfs.rs | Added metrics counter for bucket creation operations |
| rustfs/src/server/http.rs | Added metrics counter for API request tracking with method and path labels |
| rustfs/src/main.rs | Removed DNS resolver initialization code |
| rustfs/Cargo.toml | Added metrics dependency |
| crates/utils/src/net.rs | Removed custom DNS resolver fallback logic and test setup |
| crates/utils/src/lib.rs | Removed public export of DNS resolver module |
| crates/utils/src/dns_resolver.rs | Commented out entire DNS resolver implementation |
| crates/utils/Cargo.toml | Removed hickory-resolver and moka dependencies from net feature |
| crates/rio/Cargo.toml | Removed unused base64-simd dependency |
| crates/obs/src/telemetry.rs | Added metrics recorder initialization and startup counter |
| crates/obs/Cargo.toml | Added metrics dependencies, removed tracing-core |
| crates/iam/Cargo.toml | Removed unused rustfs-config dependency |
| crates/ecstore/src/config/mod.rs | Removed blank line |
| Cargo.toml | Bumped multiple dependency versions and removed unused profile configurations |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 14 out of 15 changed files in this pull request and generated 1 comment.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Type of Change
Related Issues
Summary of Changes
chore: bump dependencies, add metrics support, remove DNS resolver
Bump multiple crate versions to latest compatible releases to address security
fixes and dependency drift. Ran
cargo updateand adjusted code for minorAPI changes where required.
Introduce metrics collection via the
metricscrate:metricsdependency and initialize basic metrics plumbing.delete_object, multipart operations, etc.) with counters and key metrics.
&strlifetimes and OnceCell invariants).
Remove custom DNS resolver feature:
Fixes and tidy-ups:
initialization (avoid Box::leak and static reference escapes).
BREAKING CHANGES:
migrate to system DNS or reintroduce a resolver implementation.
on leaked
&'staticstrings should be updated.Migration notes:
cargo updatethencargo buildto apply dependency changes.expect metrics to be exported.
Checklist
make pre-commitImpact
Additional Notes
Thank you for your contribution! Please ensure your PR follows the community standards (CODE_OF_CONDUCT.md) and sign the CLA if this is your first contribution.