Skip to content

Conversation

@houseme
Copy link
Contributor

@houseme houseme commented Oct 7, 2025

Type of Change

  • New Feature
  • Bug Fix
  • Documentation
  • Performance Improvement
  • Test/CI
  • Refactor
  • Other:

Related Issues

#629

Summary of Changes

Checklist

  • I have read and followed the CONTRIBUTING.md guidelines
  • Passed make pre-commit
  • Added/updated necessary tests
  • Documentation updated (if needed)
  • CI/CD passed (if applicable)

Impact

  • Breaking change (compatibility)
  • Requires doc/config/deployment update
  • Other impact:

Additional Notes


Thank you for your contribution! Please ensure your PR follows the community standards (CODE_OF_CONDUCT.md) and sign the CLA if this is your first contribution.

houseme and others added 13 commits September 26, 2025 18:03
…#592)

* Initial plan

* Fix ETag format to comply with HTTP standards by wrapping with quotes

Co-authored-by: overtrue <[email protected]>

* bufigx

---------

Co-authored-by: copilot-swe-agent[bot] <[email protected]>
Co-authored-by: overtrue <[email protected]>
Co-authored-by: overtrue <[email protected]>
* improve lock

Signed-off-by: Mu junxiang <[email protected]>

* feat(tests): add wait_for_object_absence helper and improve lifecycle test reliability

Signed-off-by: Mu junxiang <[email protected]>

* chore: remove dirty docs

Signed-off-by: Mu junxiang <[email protected]>

---------

Signed-off-by: Mu junxiang <[email protected]>
…599)

* feat(append): implement object append operations with state tracking

Signed-off-by: junxiang Mu <[email protected]>

* chore: rebase

Signed-off-by: junxiang Mu <[email protected]>

---------

Signed-off-by: junxiang Mu <[email protected]>
@github-actions
Copy link

github-actions bot commented Oct 7, 2025

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

* feature/audit-add-logger:
  fix
  improve code for `import`
  fix: validate mqtt broker
  build(deps): upgrade s3s (#595)
  feat(append): implement object append operations with state tracking (#599)
  Improve lock (#596)
  Fix ETag format to comply with HTTP standards by wrapping with quotes (#592)
  upgrade version
  upgrade starshard version
  feat: improve code for notify

# Conflicts:
#	Cargo.lock
#	Cargo.toml
#	rustfs/src/storage/ecfs.rs
@houseme houseme requested a review from Copilot October 10, 2025 11:00
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request refactors RustFS to upgrade its dependencies and organize imports more efficiently. It focuses on updating OpenTelemetry to version 0.31, replacing std::collections with hashbrown for performance improvements, and reorganizing imports across multiple files.

Key Changes

  • Upgraded OpenTelemetry dependencies from 0.30 to 0.31
  • Replaced std::collections with hashbrown HashMap/HashSet throughout the codebase for better performance
  • Reorganized and consolidated imports in multiple files for better readability

Reviewed Changes

Copilot reviewed 33 out of 36 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
Cargo.toml Updated OpenTelemetry and other dependency versions
rustfs/src/storage/ecfs.rs Major import consolidation and organization
crates/notify/src/notifier.rs Replaced DashMap with AsyncShardedHashMap for better performance
crates/utils/src/notify/net.rs Added new network utilities module
rustfs/src/admin/handlers/event.rs Commented out bucket notification handlers and improved MQTT validation
Multiple notify crates Replaced std::collections with hashbrown equivalents

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@houseme houseme requested a review from Copilot October 10, 2025 11:12
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 33 out of 36 changed files in this pull request and generated 3 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@houseme houseme changed the title Feature/up otel 0.31 chore: improve event and docker-compose ,Improve the permissions of the endpoint health interface, upgrade otel from 0.30.0 to 0.31.0 Oct 10, 2025
@houseme houseme requested a review from Copilot October 10, 2025 17:40
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 33 out of 36 changed files in this pull request and generated 2 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@houseme houseme merged commit aac9b1e into main Oct 11, 2025
16 checks passed
@houseme houseme deleted the feature/up-otel-0.31 branch October 11, 2025 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants