-
Notifications
You must be signed in to change notification settings - Fork 760
feat(append): implement object append operations with state tracking #599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: junxiang Mu <[email protected]>
Signed-off-by: junxiang Mu <[email protected]>
19d5220 to
b370c29
Compare
houseme
pushed a commit
that referenced
this pull request
Sep 29, 2025
…599) * feat(append): implement object append operations with state tracking Signed-off-by: junxiang Mu <[email protected]> * chore: rebase Signed-off-by: junxiang Mu <[email protected]> --------- Signed-off-by: junxiang Mu <[email protected]>
houseme
added a commit
that referenced
this pull request
Oct 7, 2025
* feature/audit-add-logger: fix improve code for `import` fix: validate mqtt broker build(deps): upgrade s3s (#595) feat(append): implement object append operations with state tracking (#599) Improve lock (#596) Fix ETag format to comply with HTTP standards by wrapping with quotes (#592) upgrade version upgrade starshard version feat: improve code for notify # Conflicts: # Cargo.lock # Cargo.toml # rustfs/src/storage/ecfs.rs
houseme
added a commit
that referenced
this pull request
Oct 11, 2025
…he `endpoint` health interface, upgrade otel from 0.30.0 to 0.31.0 (#620) * feat: improve code for notify * upgrade starshard version * upgrade version * Fix ETag format to comply with HTTP standards by wrapping with quotes (#592) * Initial plan * Fix ETag format to comply with HTTP standards by wrapping with quotes Co-authored-by: overtrue <[email protected]> * bufigx --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: overtrue <[email protected]> Co-authored-by: overtrue <[email protected]> * Improve lock (#596) * improve lock Signed-off-by: Mu junxiang <[email protected]> * feat(tests): add wait_for_object_absence helper and improve lifecycle test reliability Signed-off-by: Mu junxiang <[email protected]> * chore: remove dirty docs Signed-off-by: Mu junxiang <[email protected]> --------- Signed-off-by: Mu junxiang <[email protected]> * feat(append): implement object append operations with state tracking (#599) * feat(append): implement object append operations with state tracking Signed-off-by: junxiang Mu <[email protected]> * chore: rebase Signed-off-by: junxiang Mu <[email protected]> --------- Signed-off-by: junxiang Mu <[email protected]> * build(deps): upgrade s3s (#595) Co-authored-by: loverustfs <[email protected]> * fix: validate mqtt broker * improve code for `import` * upgrade otel relation crates version * fix:dep("jsonwebtoken") feature = 'rust_crypto' * fix * fix * fix * upgrade version * improve code for ecfs * chore: improve event and docker-compose ,Improve the permissions of the `endpoint` health interface * fix * fix * fix * fix * improve code * fix --------- Signed-off-by: Mu junxiang <[email protected]> Signed-off-by: junxiang Mu <[email protected]> Co-authored-by: Copilot <[email protected]> Co-authored-by: overtrue <[email protected]> Co-authored-by: overtrue <[email protected]> Co-authored-by: guojidan <[email protected]> Co-authored-by: Nugine <[email protected]> Co-authored-by: loverustfs <[email protected]>
This was referenced Oct 11, 2025
overtrue
added a commit
that referenced
this pull request
Oct 12, 2025
问题描述: PR #599 引入的 append 功能在删除对象时只清理了主数据目录, 未清理 {object}/append/{epoch}/{uuid} 下的 pending segments, 导致磁盘空间泄漏和无法完全删除文件。 修复内容: 1. 在 delete_version 方法中添加 append segments 清理逻辑 2. 在 delete_versions_internal 方法中添加相同的清理逻辑 3. 从磁盘存储的 FileMeta 中正确提取 append state 4. 添加测试用例验证修复有效性 测试结果: - 新增 2 个 e2e 测试全部通过 - ecstore 包 300 个测试全部通过 - 未破坏任何现有功能
6 tasks
houseme
added a commit
that referenced
this pull request
Oct 17, 2025
…eappearing entries (#662) * feat: improve code for notify * upgrade starshard version * upgrade version * Fix ETag format to comply with HTTP standards by wrapping with quotes (#592) * Initial plan * Fix ETag format to comply with HTTP standards by wrapping with quotes Co-authored-by: overtrue <[email protected]> * bufigx --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: overtrue <[email protected]> Co-authored-by: overtrue <[email protected]> * Improve lock (#596) * improve lock Signed-off-by: Mu junxiang <[email protected]> * feat(tests): add wait_for_object_absence helper and improve lifecycle test reliability Signed-off-by: Mu junxiang <[email protected]> * chore: remove dirty docs Signed-off-by: Mu junxiang <[email protected]> --------- Signed-off-by: Mu junxiang <[email protected]> * feat(append): implement object append operations with state tracking (#599) * feat(append): implement object append operations with state tracking Signed-off-by: junxiang Mu <[email protected]> * chore: rebase Signed-off-by: junxiang Mu <[email protected]> --------- Signed-off-by: junxiang Mu <[email protected]> * build(deps): upgrade s3s (#595) Co-authored-by: loverustfs <[email protected]> * fix: validate mqtt broker * improve code for `import` * fix * improve * remove logger from `rustfs-obs` crate * remove code for config Observability * fix * improve code * fix comment * up * up * upgrade version * fix * fmt * upgrade tokio version to 1.48.0 * upgrade `datafusion` and `reed-solomon-simd` version * fix * fmt * improve code for notify webhook example * improve code * fix * fix * fmt --------- Signed-off-by: Mu junxiang <[email protected]> Signed-off-by: junxiang Mu <[email protected]> Co-authored-by: Copilot <[email protected]> Co-authored-by: overtrue <[email protected]> Co-authored-by: overtrue <[email protected]> Co-authored-by: guojidan <[email protected]> Co-authored-by: Nugine <[email protected]> Co-authored-by: loverustfs <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Related Issues
Summary of Changes
Checklist
make pre-commitImpact
Additional Notes
Thank you for your contribution! Please ensure your PR follows the community standards (CODE_OF_CONDUCT.md) and sign the CLA if this is your first contribution.