fix: decode percent-encoded paths in get_file_path() #1072

jacoblyles · 2025-12-08T16:24:41Z

Type of Change

Related Issues

Summary of Changes

Paths containing spaces (e.g., macOS ~/Library/Application Support/) get percent-encoded when converted to URLs (%20 for spaces). This caused "Volume not found" errors when rustfs tried to access paths with their encoded form instead of the actual filesystem path.

Changes:

get_file_path() now returns String and decodes percent-encoded chars
Updated endpoints.rs to handle the new String return type
Added test for paths with spaces

Checklist

I have read and followed the CONTRIBUTING.md guidelines
Passed make pre-commit
Added/updated necessary tests
Documentation updated (if needed)
CI/CD passed (if applicable)

Impact

Breaking change (compatibility)
Requires doc/config/deployment update
Other impact:

Additional Notes

This fixes the issue where rustfs data directories in paths with spaces would fail to be found.

Paths containing spaces (e.g., macOS ~/Library/Application Support/) get percent-encoded when converted to URLs (%20 for spaces). This caused "Volume not found" errors when rustfs tried to access paths with their encoded form instead of the actual filesystem path. Changes: - get_file_path() now returns String and decodes percent-encoded chars - Updated endpoints.rs to handle the new String return type - Added test for paths with spaces This fixes the issue where rustfs data directories in paths with spaces would fail to be found.

CLAassistant · 2025-12-08T16:24:55Z

All committers have signed the CLA.

Copilot

Pull request overview

This PR fixes a bug where paths containing spaces (or other characters that get percent-encoded when converted to URLs) caused "Volume not found" errors. The issue occurred because get_file_path() was returning the percent-encoded path string (e.g., Application%20Support) instead of decoding it back to the actual filesystem path (e.g., Application Support).

Changed get_file_path() to decode percent-encoded URLs before returning the path
Updated endpoints.rs to handle the new String return type instead of &str
Added test coverage for paths containing spaces

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
crates/ecstore/src/disk/endpoint.rs	Modified `get_file_path()` to return `String` and decode percent-encoded characters using `urlencoding::decode()`; added test for paths with spaces
crates/ecstore/src/endpoints.rs	Updated HashMap types and references to work with `String` return type from `get_file_path()` instead of `&str`

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

crates/ecstore/src/disk/endpoint.rs

loverustfs · 2025-12-09T02:22:26Z

Hey @jacoblyles ,

Could you please add some types?


let url_with_encoded_spaces = "file:///Users/test/Library/Application%20Support/rustfs/data";
let endpoint = Endpoint::try_from(url_with_encoded_spaces).unwrap();
assert_eq!(endpoint.get_file_path(), "/Users/test/Library/Application Support/rustfs/data");

Thanks.

- Add test_endpoint_percent_encoding_roundtrip to verify URL stores percent-encoded path and get_file_path() decodes it correctly - Add test_endpoint_with_various_special_characters to test paths with spaces, brackets, and hash characters

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

crates/ecstore/src/disk/endpoint.rs

crates/ecstore/src/endpoints.rs

loverustfs · 2025-12-10T02:59:31Z

Hey @jacoblyles ,

Automated test failed.


  Cancelling due to test failure: 3 tests still running
        PASS [   5.250s] ( 360/1964) rustfs-ahm::heal_integration_test serial_tests::test_heal_format_basic
        PASS [   5.263s] ( 361/1964) rustfs-ahm::heal_integration_test serial_tests::test_heal_bucket_basic
        PASS [   5.205s] ( 362/1964) rustfs-ahm::heal_integration_test serial_tests::test_heal_format_with_data
────────────
     Summary [   7.353s] 362/1964 tests run: 361 passed, 1 failed, 23 skipped
        FAIL [   1.853s] ( 359/1964) rustfs::bin/rustfs storage::concurrent_get_object_test::tests::bench_concurrent_cache_performance
warning: 1602/1964 tests were not run due to test failure (run with --no-fail-fast to run all tests, or run with --max-fail)
error: test run failed
Error: Process completed with exit code 100.

jacoblyles · 2025-12-10T13:36:46Z

Hey @jacoblyles ,

Automated test failed.


  Cancelling due to test failure: 3 tests still running
        PASS [   5.250s] ( 360/1964) rustfs-ahm::heal_integration_test serial_tests::test_heal_format_basic
        PASS [   5.263s] ( 361/1964) rustfs-ahm::heal_integration_test serial_tests::test_heal_bucket_basic
        PASS [   5.205s] ( 362/1964) rustfs-ahm::heal_integration_test serial_tests::test_heal_format_with_data
────────────
     Summary [   7.353s] 362/1964 tests run: 361 passed, 1 failed, 23 skipped
        FAIL [   1.853s] ( 359/1964) rustfs::bin/rustfs storage::concurrent_get_object_test::tests::bench_concurrent_cache_performance
warning: 1602/1964 tests were not run due to test failure (run with --no-fail-fast to run all tests, or run with --max-fail)
error: test run failed
Error: Process completed with exit code 100.

Looks like a flakey test unrelated to my changes. How to rerun?

- Add debug logging when percent-decoding fails in get_file_path() - Use test path without URL fragment semantics (#) to avoid confusion

loverustfs · 2025-12-10T14:30:35Z

Hey @jacoblyles ,

Thank you for your contribution! We have merged the code.

jacoblyles marked this pull request as draft December 8, 2025 16:28

jacoblyles marked this pull request as ready for review December 8, 2025 17:10

houseme requested review from Copilot, houseme, shiroleeee and weisd and removed request for weisd December 9, 2025 01:12

Copilot started reviewing on behalf of houseme December 9, 2025 01:12 View session

Copilot AI reviewed Dec 9, 2025

View reviewed changes

crates/ecstore/src/disk/endpoint.rs Show resolved Hide resolved

loverustfs mentioned this pull request Dec 9, 2025

Special Chars in path #1074

Closed

Copilot AI mentioned this pull request Dec 9, 2025

Add comprehensive special character handling with validation refactoring and extensive test coverage #1078

Merged

12 tasks

houseme added 2 commits December 9, 2025 13:58

Merge branch 'main' into fix-space-in-path

45e855a

Merge branch 'main' into fix-space-in-path

f6634f9

houseme assigned houseme and unassigned houseme Dec 9, 2025

jacoblyles added 2 commits December 9, 2025 13:08

style: add explicit type annotations to get_file_path()

bf13221

houseme requested a review from Copilot December 10, 2025 01:21

Copilot started reviewing on behalf of houseme December 10, 2025 01:21 View session

Copilot AI reviewed Dec 10, 2025

View reviewed changes

crates/ecstore/src/disk/endpoint.rs Outdated Show resolved Hide resolved

crates/ecstore/src/disk/endpoint.rs Outdated Show resolved Hide resolved

crates/ecstore/src/disk/endpoint.rs Outdated Show resolved Hide resolved

crates/ecstore/src/endpoints.rs Show resolved Hide resolved

loverustfs added 2 commits December 10, 2025 13:46

Merge branch 'main' into fix-space-in-path

b4d2bc9

Merge branch 'main' into fix-space-in-path

f3b3326

houseme and others added 2 commits December 10, 2025 22:09

Merge branch 'main' into fix-space-in-path

4bb2ac1

refactor: address PR review feedback

c8f1cf1

- Add debug logging when percent-decoding fails in get_file_path() - Use test path without URL fragment semantics (#) to avoid confusion

loverustfs merged commit 53c126d into rustfs:main Dec 10, 2025
12 of 13 checks passed

loverustfs mentioned this pull request Dec 10, 2025

VolumeNotFound error when data path contains spaces #1011

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: decode percent-encoded paths in get_file_path() #1072

fix: decode percent-encoded paths in get_file_path() #1072

jacoblyles commented Dec 8, 2025 •

edited

Loading

Uh oh!

CLAassistant commented Dec 8, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

loverustfs commented Dec 9, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

loverustfs commented Dec 10, 2025

Uh oh!

jacoblyles commented Dec 10, 2025

Uh oh!

Uh oh!

loverustfs commented Dec 10, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

fix: decode percent-encoded paths in get_file_path() #1072

fix: decode percent-encoded paths in get_file_path() #1072

Conversation

jacoblyles commented Dec 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Type of Change

Related Issues

Summary of Changes

Checklist

Impact

Additional Notes

Uh oh!

CLAassistant commented Dec 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

loverustfs commented Dec 9, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

loverustfs commented Dec 10, 2025

Uh oh!

jacoblyles commented Dec 10, 2025

Uh oh!

Uh oh!

loverustfs commented Dec 10, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

jacoblyles commented Dec 8, 2025 •

edited

Loading

CLAassistant commented Dec 8, 2025 •

edited

Loading