feat: add is-admin user api #1063
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houseme
approved these changes
Dec 8, 2025
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a new admin API endpoint to check whether a user has administrator privileges. The endpoint validates user credentials and compares them against the system's global admin credentials.
- Adds a new
/rustfs/admin/v3/is-adminGET endpoint - Implements authentication check using existing credential validation
- Returns JSON response indicating admin status with access key and message
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| rustfs/src/admin/mod.rs | Registers the new IsAdminHandler to the admin route with GET method at /rustfs/admin/v3/is-admin path |
| rustfs/src/admin/handlers.rs | Implements IsAdminResponse struct and IsAdminHandler operation to validate credentials and check admin status against global credentials |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
@yxrxy please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1020
closes: #1064
Type of Change
Related Issues
Summary of Changes
Checklist
make pre-commitThank you for your contribution! Please ensure your PR follows the community standards (CODE_OF_CONDUCT.md) and sign the CLA if this is your first contribution.