Feature/improve profiling #1038
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: weisd <[email protected]> Co-authored-by: houseme <[email protected]>
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors profiling support to be more platform-aware, restricting jemalloc-based profiling to x86_64 Linux GNU systems while using mimalloc as the allocator for all other platforms. The changes also extract initialization functions into a separate init.rs module for better code organization.
Key changes:
- Platform-specific allocator configuration: jemalloc for x86_64 Linux GNU, mimalloc for all other platforms
- Profiling features now restricted to platforms with jemalloc support
- Initialization functions moved from
main.rsto newinit.rsmodule
Reviewed changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| rustfs/src/profiling.rs | Updated conditional compilation to restrict profiling to x86_64 Linux GNU; added informative logging for unsupported platforms |
| rustfs/src/main.rs | Updated allocator selection logic; removed initialization functions (moved to init.rs); switched to rustfs_utils::get_env_bool |
| rustfs/src/init.rs | New module containing extracted initialization functions for update checks, KMS, buffer profiling, and bucket notifications |
| rustfs/src/admin/handlers/profile.rs | Removed platform-specific conditional compilation in favor of runtime error handling; added large blocks of commented-out code |
| rustfs/src/admin/handlers.rs | Updated conditional compilation for profile handlers to match new platform restrictions |
| rustfs/Cargo.toml | Reconfigured allocator dependencies: jemalloc dependencies restricted to x86_64 Linux GNU; mimalloc for all other platforms |
| Cargo.toml | Updated axum-server to 0.8.0 and local-ip-address to 0.6.6; reorganized mimalloc placement |
| Cargo.lock | Dependency lock updates reflecting version changes and new transitive dependencies |
| docs/bug_resolution_report_issue_1013.md | New documentation explaining the jemalloc page size issue on AArch64 and the solution implemented |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 8 out of 9 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 8 out of 9 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 8 out of 9 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Related Issues
#1013Summary of Changes
Checklist
make pre-commitImpact
Additional Notes
Thank you for your contribution! Please ensure your PR follows the community standards (CODE_OF_CONDUCT.md) and sign the CLA if this is your first contribution.