feat(helm): split storageSize into data and log storage parameters #1018
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Contributor
|
@LemonDouble Thanks for your PR. It looks good. /LGTM /cc @loverustfs @houseme |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Related Issues
closes #1006
Summary of Changes
Checklist
make pre-commitImpact
Breaking change (compatibility)
Requires doc/config/deployment update
Other impact:
Additional Notes
The
storageclass.sizeparameter has been split into two separate parameters:storageclass.dataStorageSize: Storage size for data PVC (default:256Mi)storageclass.logStorageSize: Storage size for log PVC (default:256Mi)Migration required: Users who previously set
storageclass.sizemust update their configurations to usestorageclass.dataStorageSizeandstorageclass.logStorageSizeinstead.Thank you for your contribution! Please ensure your PR follows the community standards (CODE_OF_CONDUCT.md) and sign the CLA if this is your first contribution.