Skip to content

Conversation

@0xdx2
Copy link
Contributor

@0xdx2 0xdx2 commented Dec 5, 2025

…perations

Type of Change

  • New Feature
  • Bug Fix
  • Documentation
  • Performance Improvement
  • Test/CI
  • Refactor
  • Other:

Related Issues

#489
aws-go-sdk can not pass

s3s-project/s3s#408

  1. ChecksumCRC32:
    https://github.com/minio/mint/blob/master/run/core/aws-sdk-go-v2/main.go#L838
if !strings.Contains(err.Error(), "BadDigest") && !strings.Contains(err.Error(), "InvalidRequest") && !strings.Contains(err.Error(), "400") {
		failureLog(function, args, startTime, "", fmt.Sprintf("AWS SDK Go V2 expected checksum error but got: %v", err), err).Fatal()
		return
	}
  1. delete_object:
    https://github.com/minio/mint/blob/master/run/core/aws-sdk-go-v2/main.go#L479
// Verify error is PreconditionFailed
if !strings.Contains(err.Error(), "PreconditionFailed") && !strings.Contains(err.Error(), "412") {
		failureLog(function, args, startTime, "", fmt.Sprintf("AWS SDK Go V2 expected PreconditionFailed error but got: %v", err), err).Fatal()
		return
	}
  1. except put object and copy object, checkPreconditions
    https://github.com/minio/minio/blob/master/cmd/object-handlers-common.go#L238

  2. tag_set.length can not great than 10
    https://github.com/minio/mint/blob/master/run/core/aws-sdk-go-v2/main.go#L1647

if errors.As(err, &apiErr) {
		if apiErr.ErrorCode() != "BadRequest" {
			failureLog(function, args, startTime, "", fmt.Sprintf("AWS SDK Go V2 PUT expected to fail but got %v", err), err).Fatal()
			return
		}
	}

Summary of Changes

Checklist

  • I have read and followed the CONTRIBUTING.md guidelines
  • Passed make pre-commit
  • Added/updated necessary tests
  • Documentation updated (if needed)
  • CI/CD passed (if applicable)

Impact

  • Breaking change (compatibility)
  • Requires doc/config/deployment update
  • Other impact:

Additional Notes


Thank you for your contribution! Please ensure your PR follows the community standards (CODE_OF_CONDUCT.md) and sign the CLA if this is your first contribution.

@weisd weisd merged commit 7c6cbaf into rustfs:main Dec 6, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants