On Windows, fix window shrinking when leaving fullscreen in some situations#718
Conversation
|
Thanks for the quick fix! I think a CHANGELOG entry would be nice. This introduces another fun bug that makes the window grow:
|
|
@francesca64 Heh, funny that this would add a bug that does exactly the opposite of the original bug! Regardless, Windows now saves the client rect instead of the adjusted window rect when we enter fullscreen so this and any similar issues should be fixed. |
|
Awesome! This next one isn't a regression, but might make sense to tackle here too:
This progressively makes the window shorter by the same height as the title bar. |
|
We're using the official Windows restore-size-from-maximize function there, so fixing that would involve a bit more work than I'm willing to do in this PR. I'm working on a bigger refactor to the Windows style-flags code though (which touches that), so I'll see about fixing it in that. |
|
Alright, sounds great! |
2 participants
CHANGELOG.mdif knowledge of this change could be valuable to usersFixes #715. This seems to have been caused by the window style getting improperly set when leaving fullscreen mode.
The Windows fullscreen window restore code is a bit convoluted in general so I'd like to take some time to refactor and simplify that a bit, but this can be fixed without doing that.