fix(macOS) "fix" toggling IME on appkit backend#4512
Merged
madsmtm merged 1 commit intorust-windowing:masterfrom Mar 14, 2026
Merged
fix(macOS) "fix" toggling IME on appkit backend#4512madsmtm merged 1 commit intorust-windowing:masterfrom
madsmtm merged 1 commit intorust-windowing:masterfrom
Conversation
Random-Scientist
force-pushed
the
master
branch
from
642c99d to
84034cf
Compare
Random-Scientist
force-pushed
the
master
branch
from
84034cf to
2b47447
Compare
madsmtm
added
DS - appkit
madsmtm
approved these changes
Mar 14, 2026
Member
madsmtm
left a comment
madsmtm
left a comment
There was a problem hiding this comment.
Thanks!
I'd probably be fine with trimming things further here, a lot of these things really should be unnecessary and I'm not as worried about breaking enable/disable as I am about the rest, but also fine with keeping it for now.
junglie85
pushed a commit
to junglie85/winit
that referenced
this pull request
Mar 14, 2026
Co-authored-by: Random-Scientist <[email protected]>
This was referenced Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
changelogmodule if knowledge of this change could be valuable to usersFixes #4432, although there are still countless other bugs in the implementation. For context, I'm planning on experimenting with a rewrite of the appkit IME backend, based loosely on Chromium's workarounds, and this makes the internal api a bit nicer for that. It's also an easy "harm reduction" fix for a simple bug (unlike the rest of the NSTextInputClient related issues).