Skip to content

macOS: Close windows automatically when exiting#4154

Merged
madsmtm merged 2 commits intomasterfrom
madsmtm/macos-close-windows-automatically
Mar 17, 2025
Merged

macOS: Close windows automatically when exiting#4154
madsmtm merged 2 commits intomasterfrom
madsmtm/macos-close-windows-automatically

Conversation

@madsmtm
Copy link
Copy Markdown
Member

@madsmtm madsmtm commented Mar 1, 2025

This disallows carrying over open windows between calls of run_app_on_demand (which wasn't intended to be supported anyhow). Wasn't nearly as hard as I feared. Fixes #4135.

I looked a bit back, seems this was noted in #2767 (review) too, but never resolved.

  • Tested on all platforms changed
  • Added an entry to the changelog module if knowledge of this change could be valuable to users

@madsmtm madsmtm added B - bug Dang, that shouldn't have happened DS - appkit Affects the AppKit/macOS backend labels Mar 1, 2025
@madsmtm madsmtm added this to the Version 0.30.10 milestone Mar 1, 2025
@madsmtm madsmtm force-pushed the madsmtm/macos-close-windows-automatically branch 2 times, most recently from f4bc7ea to ee523f0 Compare March 1, 2025 20:33
@kchibisov
Copy link
Copy Markdown
Member

I'd assume the Destroyed is emitted for them? If so, then it's fine.

@madsmtm
Copy link
Copy Markdown
Member Author

madsmtm commented Mar 17, 2025

Yup, that's the point.

@madsmtm madsmtm force-pushed the madsmtm/macos-close-windows-automatically branch from ee523f0 to 9007145 Compare March 17, 2025 10:01
@madsmtm madsmtm merged commit 8db4a9c into master Mar 17, 2025
57 checks passed
@madsmtm madsmtm deleted the madsmtm/macos-close-windows-automatically branch March 17, 2025 10:29
@madsmtm madsmtm mentioned this pull request Apr 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

B - bug Dang, that shouldn't have happened DS - appkit Affects the AppKit/macOS backend

Development

Successfully merging this pull request may close these issues.

Winit window does not close after exit, but stays in a Not responding state

2 participants