Conversation
madsmtm
force-pushed
the
macos-visible-rect-frame
branch
from
0540f8b to
31cc3ce
Compare
madsmtm
added a commit
that referenced
this pull request
Sep 27, 2023
oneElectron
added a commit
to oneElectron/winit
that referenced
this pull request
Oct 13, 2023
kchibisov
pushed a commit
to kchibisov/winit
that referenced
this pull request
Oct 17, 2023
kchibisov
pushed a commit
that referenced
this pull request
Oct 21, 2023
rib
pushed a commit
to EmbarkStudios/winit
that referenced
this pull request
Dec 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were invalidly using
visibleRectwhere we should have been usingframe; the former is used if your view is in e.g. a scroll view, and you want to save resources by only rendering the visible part of the view.This is confusing, since
visibleRectis put under the drawing collection in the documentation, so I've banned it from our codebase usingclippy.tomlto avoid this issue in the future (though that will only take effect after #2982).Fixes #2876
CHANGELOG.mdif knowledge of this change could be valuable to users