Skip to content

Only enable instant/wasm-bindgen when building for wasm32 architecture#2738

Closed
gferon wants to merge 1 commit intorust-windowing:masterfrom
gferon:winit-wasm-bindgen-optional
Closed

Only enable instant/wasm-bindgen when building for wasm32 architecture#2738
gferon wants to merge 1 commit intorust-windowing:masterfrom
gferon:winit-wasm-bindgen-optional

Conversation

@gferon
Copy link
Copy Markdown

@gferon gferon commented Mar 13, 2023

This is the mirror change of emilk/egui#2808 to fix compilation with bazel.

@gferon gferon force-pushed the winit-wasm-bindgen-optional branch from 4f4a2ea to b8ecc00 Compare March 13, 2023 17:18
@daxpedda
Copy link
Copy Markdown
Member

While we are at it, I would like to suggest removing it completely from native builds.
There are only two places that need a cfg guard anyway:

Examples can be kept by just adding it to the dev-dependencies ... only one example anyway.

@daxpedda daxpedda added DS - web Affects the Web backend (WebAssembly/WASM) C - waiting on author Waiting for a response or another PR labels May 28, 2023
@gferon gferon closed this May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C - waiting on author Waiting for a response or another PR DS - web Affects the Web backend (WebAssembly/WASM)

Development

Successfully merging this pull request may close these issues.

2 participants