Skip to content

Fix value in MouseButton::Other on Windows#2565

Merged
madsmtm merged 2 commits intorust-windowing:masterfrom
madsmtm:fix-windows-mousebutton-other
Nov 23, 2022
Merged

Fix value in MouseButton::Other on Windows#2565
madsmtm merged 2 commits intorust-windowing:masterfrom
madsmtm:fix-windows-mousebutton-other

Conversation

@madsmtm
Copy link
Copy Markdown
Member

@madsmtm madsmtm commented Nov 22, 2022 •
edited
Loading

Fixes #2562 and probably fixes #2563.

This was a mistake in #2057.

We used winapi's GET_XBUTTON_WPARAM before which is using HIWORD instead of LOWORD.

  • Tested on all platforms changed
  • Added an entry to CHANGELOG.md if knowledge of this change could be valuable to users
  • Updated documentation to reflect any user-facing changes, including notes of platform-specific behavior
  • Created or updated an example program if it would help users understand this functionality
  • Updated feature matrix, if new features were added or implemented

@madsmtm
Fix MouseButton::Other value on Windows
69d1a2c 
This was a mistake in the transition to windows-sys: rust-windowing#2057

We used winapi's GET_XBUTTON_WPARAM before which is using HIWORD instead of LOWORD: https://docs.rs/winapi/0.3.9/src/winapi/um/winuser.rs.html#1297-1299
@madsmtm madsmtm added B - bug Dang, that shouldn't have happened DS - win32 Affects the Win32/Windows backend labels Nov 22, 2022
@madsmtm madsmtm requested a review from msiglreith as a code owner November 22, 2022 21:23
@madsmtm madsmtm mentioned this pull request Nov 22, 2022
Closed
@madsmtm
Copy link
Copy Markdown
Member Author

madsmtm commented Nov 22, 2022

We might want to include this in a patch version to v0.27? (@kchibisov)

@madsmtm madsmtm mentioned this pull request Nov 22, 2022
Closed
@madsmtm madsmtm added this to the Version 0.28 milestone Nov 23, 2022
@madsmtm madsmtm merged commit a63b066 into rust-windowing:master Nov 23, 2022
@madsmtm madsmtm deleted the fix-windows-mousebutton-other branch November 23, 2022 15:44
@msiglreith msiglreith mentioned this pull request Mar 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@msiglreith msiglreith msiglreith approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

B - bug Dang, that shouldn't have happened DS - win32 Affects the Win32/Windows backend

Milestone

Version 0.28

2 participants

@madsmtm @msiglreith