Add method to hook xlib error handler#2385
Merged
kchibisov merged 1 commit intorust-windowing:masterfrom Jul 22, 2022
Merged
Conversation
kchibisov
force-pushed
the
xlib-error-handling
branch
from
4670213 to
461a5c4
Compare
maroider
reviewed
Jul 21, 2022
kchibisov
force-pushed
the
xlib-error-handling
branch
from
461a5c4 to
7503fee
Compare
kchibisov
force-pushed
the
xlib-error-handling
branch
from
7503fee to
7b98a70
Compare
maroider
approved these changes
Jul 22, 2022
Contributor
|
I'd rather it be a |
Member
Author
|
I thought about, but I'm not sure. Given that it must be send + sync. |
Member
|
If we want closures, then I don't think there's necessarily anything wrong with requiring said closures to be |
This should help glutin to handle errors coming from GLX and provide multithreading access in a safe way. Fixes rust-windowing#2378.
kchibisov
force-pushed
the
xlib-error-handling
branch
from
7b98a70 to
18d3fa9
Compare
Member
Author
|
I've updated to use closures instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should help glutin to handle errors coming from GLX
and provide multithreading access in a safe way.
Fixes #2378.