Refine Window::set_cursor_grab API#2329
Merged
kchibisov merged 3 commits intorust-windowing:masterfrom Jun 13, 2022
Merged
Conversation
madsmtm
requested changes
Jun 11, 2022
Member
madsmtm
left a comment
madsmtm
left a comment
There was a problem hiding this comment.
Nice, we should definitely do this!
maroider
reviewed
Jun 11, 2022
Member
maroider
left a comment
maroider
left a comment
There was a problem hiding this comment.
I like what you're going for here
kchibisov
force-pushed
the
cursor-locking-api
branch
from
5feeb0b to
260eeb2
Compare
This commit renames `Window::set_cursor_grab` to `Window::set_cursor_grab_mode`. The new API now accepts enumeration to control the way cursor grab is performed. The value could be: `lock`, `confine`, or `none`. This commit also implements `Window::set_cursor_position` for Wayland, since it's tied to locked cursor. Implements API from rust-windowing#1677.
msiglreith
approved these changes
Jun 12, 2022
kchibisov
force-pushed
the
cursor-locking-api
branch
from
260eeb2 to
84007e3
Compare
maroider
approved these changes
Jun 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit renames
Window::set_cursor_grabtoWindow::set_cursor_grab_mode. The new API now accepts enumerationto control the way cursor grab is performed. The value could be:
lock,confine, ornone.This commit also implements
Window::set_cursor_positionfor Wayland,since it's tied to locked cursor.
Implements API from #1677.