Unify with_app_id and with_class methods#2250
Merged
kchibisov merged 1 commit intorust-windowing:masterfrom Apr 19, 2022
Merged
Unify with_app_id and with_class methods#2250kchibisov merged 1 commit intorust-windowing:masterfrom
with_app_id and with_class methods#2250kchibisov merged 1 commit intorust-windowing:masterfrom
Conversation
chrisduerr
approved these changes
Apr 9, 2022
Contributor
chrisduerr
left a comment
chrisduerr
left a comment
There was a problem hiding this comment.
Other than the minor text refinement, this looks good to me.
msiglreith
added
DS - x11
kchibisov
force-pushed
the
unify-name-setter
branch
from
a928bca to
f026e28
Compare
madsmtm
approved these changes
Apr 17, 2022
maroider
reviewed
Apr 18, 2022
Both APIs are used to set application name. This commit unifies the API between Wayland and X11, so downstream applications can remove platform specific code in that case. Fixes rust-windowing#1739.
kchibisov
force-pushed
the
unify-name-setter
branch
from
f026e28 to
a78e801
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both APIs are used to set application name. This commit unifies the API
between Wayland and X11, so downstream applications can remove platform
specific code here.
Fixes #1739.
cc @chrisduerr