Skip to content

fix: distinguish grab and grabbing cursors#1154

Merged
goddessfreya merged 2 commits intorust-windowing:masterfrom
ayazhafiz:fix/macos-grab
Sep 12, 2019
Merged

fix: distinguish grab and grabbing cursors#1154
goddessfreya merged 2 commits intorust-windowing:masterfrom
ayazhafiz:fix/macos-grab

Conversation

@ayazhafiz
Copy link
Copy Markdown
Contributor

On MacOS, there is a difference between a "grab" cursor and a "grabbing"
cursor, where "grab" is an open-hand cursor used during a hover, and
"grabbing" is a closed-hand cursor used on a click. These, and other
native MacOS cursors, can be seen at the NSCursor documentation.

See iced-rs/iced#9 for the motivation for this PR.

  • Tested on all platforms changed
  • Compilation warnings were addressed
  • cargo fmt has been run on this branch
  • Added an entry to CHANGELOG.md if knowledge of this change could be valuable to users
  • Updated documentation to reflect any user-facing changes, including notes of platform-specific behavior
  • Created or updated an example program if it would help users understand this functionality
    • N/A
  • Updated feature matrix, if new features were added or implemented
    • N/A

On macOS, there is a difference between a "grab" cursor and a "grabbing"
cursor, where "grab" is an open-hand cursor used during a hover, and
"grabbing" is a closed-hand cursor used on a click. These, and other
native MacOS cursors, can be seen at the [NSCursor documentation](https://developer.apple.com/documentation/appkit/nscursor?language=objc).

See iced-rs/iced#9 for the motivation for this
PR.
Copy link
Copy Markdown
Contributor

@goddessfreya goddessfreya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. LGTM.

@goddessfreya goddessfreya merged commit 36f4ecc into rust-windowing:master Sep 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants