Process WM_SYSCOMMAND to forbid screen savers in fullscreen mode#1065
Process WM_SYSCOMMAND to forbid screen savers in fullscreen mode#1065goddessfreya merged 4 commits intorust-windowing:masterfrom
Conversation
|
Thanks for implementing this! These changes look good. All it needs is a changelog entry, and I'll merge it. EDIT: This behavior should probably have documentation as well. |
|
No problem at all! Where should i put this behavior in the documentation? |
|
@dam4rus I'd put it here: https://docs.rs/winit/0.20.0-alpha2/winit/window/struct.WindowBuilder.html#method.with_fullscreen I'd change this function's doc to link to |
|
Yes, and now I'd link the two docs like this: https://doc.rust-lang.org/src/alloc/vec.rs.html#284 |
|
@zegentzy I've updated the documentation for https://docs.rs/winit/0.20.0-alpha2/winit/window/struct.WindowBuilder.html#method.with_fullscreen, but shouldn't we link all documentation from https://docs.rs/winit/0.20.0-alpha2/winit/window/struct.Window.html to it's WindowBuilder counterpart then? I think it would be weird if only this function is a link to another documentation. |
goddessfreya
left a comment
goddessfreya
left a comment
There was a problem hiding this comment.
Yeah, I guess that is weird. Could you open a issue for linking all the docs? I think that makes more sense than having to copies of everything. Until then, could you document it in both methods?
|
I've opened an issue for the docs change |
|
Hey @Osspial, I can't merge this 'cause rustfmt is failing. :( |
|
Can you rebase this against master, so that the CI fixes it self? |
…cumentation of window.WindowBuilder.with_fullscreen.
3 participants
Fixes #1047
Tested only on Windows 10, but should work on previous version.
cargo fmthas been run on this branchCHANGELOG.mdif knowledge of this change could be valuable to users