Merged
Conversation
goddessfreya
approved these changes
Jul 7, 2019
Osspial
reviewed
Jul 9, 2019
Contributor
Osspial
left a comment
Osspial
left a comment
There was a problem hiding this comment.
Overall, this looks good. Thanks for the PR!
src/platform_impl/ios/app_state.rs
Outdated
| // it is initially setup with a first fire time really far into the | ||
| // Create a timer with a 0.1µs interval (1ns does not work) to mimic polling. | ||
| // It is initially setup with a first fire time really far into the | ||
| // future, but that gets changed to fire immediatley in did_finish_launching |
Contributor
There was a problem hiding this comment.
While we're fixing typos, might as well do immediatley->immediately
src/platform_impl/macos/observer.rs
Outdated
| // it is initially setup with a first fire time really far into the | ||
| // Create a timer with a 0.1µs interval (1ns does not work) to mimic polling. | ||
| // It is initially setup with a first fire time really far into the | ||
| // future, but that gets changed to fire immediatley in did_finish_launching |
felixrabe
added a commit
to felixrabe/winit
that referenced
this pull request
Jul 14, 2019
* Minor doc changes * More typos
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.