-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Discuss PR merge strategies for 0.20-post-alpha #970
Copy link
Copy link
Open
Labels
C - needs discussionDirection must be ironed outDirection must be ironed outS - metaProject governanceProject governance
Description
I'd like to start a discussion regarding how we merge PRs in the future (such as after we get to 0.20 beta, for example) to make commit history more readable.
Why: Mega-commits (resulting from the current stash-the-whole-PR-into-one-commit setting) are hard to read, especially when hunting down regressions. Examples:
- 9602716 (Event Loop 2.0 API and Windows implementation (Event Loop 2.0 API and Windows implementation #638))
- d539168 (Squashed commit of the following: ([WIP] Macos Evlp2 #853))
On the other hand, I think squashing a handful of PR commits like "implemented foo" – "documented foo" – "oh, and changelog btw" into a single-commit merge is fine, as long as the resulting commit stays readable.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
C - needs discussionDirection must be ironed outDirection must be ironed outS - metaProject governanceProject governance