-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Cannot combine x11 window types. #1140
Copy link
Copy link
Closed
Labels
DS - x11Affects the X11 backend, or generally free Unix platformsAffects the X11 backend, or generally free Unix platformsH - good first issueIdeal for new contributorsIdeal for new contributorsH - help wantedSomeone please save usSomeone please save usS - apiDesign and usabilityDesign and usability
Metadata
Metadata
Assignees
Labels
DS - x11Affects the X11 backend, or generally free Unix platformsAffects the X11 backend, or generally free Unix platformsH - good first issueIdeal for new contributorsIdeal for new contributorsH - help wantedSomeone please save usSomeone please save usS - apiDesign and usabilityDesign and usability
In X11, it is possible to have multiple
_NET_WM_WINDOW_TYPEproperties, so that you can have a combination of window types.winit, however, only allows a singleXWindowType.In Xlib, if you wanted to have a window which had types
NOTIFICATIONandUTILITYyou'd do something like this:From a user perspective, I think the most obvious behaviour would be for
WindowBuilder.with_x11_window_type()to combine window types rather than replace them, but it seems to just overwrite the property:winit/src/platform/unix.rs
Lines 367 to 370 in cf0b8ba
I would be happy to contribute to fix this issue if a preferred method is described. I locally did a quick and dirty fix by pushing window types to a
Vec, which works but allows doubling up on properties. Perhaps aHashSetor bitwise OR would work better.winit = "0.20.0-alpha2"